src/ports/SkMutex_win.h - Issue 419113002: Fix thread unsafe mutex initialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkMutex_win.h

Issue 419113002: Fix thread unsafe mutex initialization. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Clang 3.5 does not like unused static inlines in .cpp. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkMutex_win.h

diff --git a/src/ports/SkMutex_win.h b/src/ports/SkMutex_win.h

index ccad063c2796c6b9ffea899ff6aa35971499e6ee..fe06336a90a0c6000e8d38c9e1f906a5750b0258 100644

--- a/src/ports/SkMutex_win.h

+++ b/src/ports/SkMutex_win.h

@@ -74,8 +74,6 @@ class SkMutex : public SkBaseMutex { };

// Windows currently provides no documented means of POD initializing a CRITICAL_SECTION.

// As a result, it is illegal to SK_DECLARE_STATIC_MUTEX in a function.

-#define SK_DECLARE_STATIC_MUTEX(name) \

- static inline void SK_MACRO_APPEND_LINE(name)(){} \

- static SkBaseMutex name

+#define SK_DECLARE_STATIC_MUTEX(name) namespace{} static SkBaseMutex name

#endif

« no previous file with comments | « src/ports/SkMutex_pthread.h ('k') | no next file » | no next file with comments »