src/ports/SkFontHost_mac.cpp - Issue 419113002: Fix thread unsafe mutex initialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkFontHost_mac.cpp

Issue 419113002: Fix thread unsafe mutex initialization. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkFontHost_mac.cpp

diff --git a/src/ports/SkFontHost_mac.cpp b/src/ports/SkFontHost_mac.cpp

index a8e1b5793e604cca91f4fdbda1bf6dd8a27731ed..2d985f94638c07a980aeed23e4af552c7bcf00e3 100755

--- a/src/ports/SkFontHost_mac.cpp

+++ b/src/ports/SkFontHost_mac.cpp

@@ -526,9 +526,9 @@ static SkTypeface* NewFromName(const char familyName[], SkTypeface::Style theSty

return ctFont ? NewFromFontRef(ctFont, familyName, false) : NULL;

}

+SK_DECLARE_STATIC_MUTEX(gGetDefaultFaceMutex);

static SkTypeface* GetDefaultFace() {

- SK_DECLARE_STATIC_MUTEX(gMutex);

- SkAutoMutexAcquire ma(gMutex);

+ SkAutoMutexAcquire ma(gGetDefaultFaceMutex);

static SkTypeface* gDefaultFace;