Handle load errors in deferred code

runtime/vm/object.h

Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h	(revision 38636)
+++ runtime/vm/object.h	(working copy)
@@ -2634,10 +2634,12 @@
   void SetLoadInProgress() const;
   bool Loaded() const { return raw_ptr()->load_state_ == RawLibrary::kLoaded; }
   void SetLoaded() const;
-  bool LoadError() const {
+  bool LoadFailed() const {
     return raw_ptr()->load_state_ == RawLibrary::kLoadError;
   }
-  void SetLoadError() const;
+  RawObject* LoadError() const { return raw_ptr()->load_error_; }

[Ivan Posva, 2014/07/31 18:29:05]

RawInstance* here and other related places.

[hausner, 2014/07/31 21:12:45]

Done.

+  void SetLoadError(const Object& error) const;
+  RawObject* TransitiveLoadError() const;
 
   static intptr_t InstanceSize() {
     return RoundedAllocationSize(sizeof(RawLibrary));
@@ -4366,9 +4368,11 @@
   virtual RawString* DictionaryName() const { return name(); }
 
   RawArray* imports() const { return raw_ptr()->imports_; }
-  intptr_t num_imports() const { return raw_ptr()->num_imports_; }
+  int32_t num_imports() const { return raw_ptr()->num_imports_; }
   RawLibrary* importer() const { return raw_ptr()->importer_; }
 
+  RawObject* LoadError() const;

[Ivan Posva, 2014/07/31 18:29:05]

Thinking about this more as I go through the CL. Can we name this something
different from Error to reduce the potential for confusion?

[hausner, 2014/07/31 21:12:45]

Leaving the name but changing to type Instance, as discussed offline.

+
   bool ContainsLibrary(const Library& library) const;
   RawLibrary* GetLibrary(int index) const;
   void AddImport(const Namespace& import) const;