Issue 419103002: Componentize ComponentUpdater: Remove erroneous task runner DCHECK in DefaultComponentInstaller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 419103002: Componentize ComponentUpdater: Remove erroneous task runner DCHECK in DefaultComponentInstaller. (Closed)

Created:
6 years, 5 months ago by tommycli

Modified:
6 years, 5 months ago

Reviewers:
waffles, cpu_(ooo_6.6-7.5)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Componentize ComponentUpdater: Remove erroneous task runner DCHECK in DefaultComponentInstaller. Removes an erroneous DCHECK added in this patch: https://codereview.chromium.org/385013002/ This DCHECK is erroneous, because the Install() function in DefaultComponentInstaller is actually called on a different task runner than the member task runner. It's called from ComponentUnpacker::Install. ComponentUnpacker has a different task runner with a different sequence token, so it's erroneous to DCHECK it against the member task runner of DefaultComponentInstaller. BUG=397264 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285526

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	chrome/browser/component_updater/default_component_installer.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/419103002/1

6 years, 5 months ago (2014-07-24 23:11:31 UTC) #4

Message was sent while issue was closed.

Change committed as 285526

Expand Messages | Collapse Messages