Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java - Issue 419073005: DevTools: [JSDocValidator] Fix function qualified name detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java

Issue 419073005: DevTools: [JSDocValidator] Fix function qualified name detection (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add a test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/AstUtil.java ('k') | Source/devtools/scripts/jsdoc-validator/tests/golden.dat » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java

diff --git a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java

index 7ea71b49a92904106e4e403a0e8fd2105456b13f..295772ed5db856b5d2ea407552adad6a9eac0575 100644

--- a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java

+++ b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java

@@ -1,6 +1,5 @@

package org.chromium.devtools.jsdoc.checks;

-import com.google.javascript.jscomp.NodeUtil;

import com.google.javascript.rhino.JSDocInfo;

import com.google.javascript.rhino.Node;

import com.google.javascript.rhino.Token;

@@ -79,7 +78,8 @@ public class ContextTrackingValidationCheck extends ValidationCheck {

TypeRecord parentType = state.getCurrentFunctionRecord() == null

? state.getCurrentTypeRecord()

: null;

- String functionName = NodeUtil.getNearestFunctionName(node);

+ Node nameNode = AstUtil.getFunctionNameNode(node);

+ String functionName = nameNode == null ? null : state.getNodeText(nameNode);

FunctionRecord functionRecord = new FunctionRecord(

node,

functionName,