Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: Source/devtools/scripts/jsdoc-validator/tests/golden.dat

Issue 419073005: DevTools: [JSDocValidator] Fix function qualified name detection (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add a test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:1: ERROR - @return annotation is requi red for API functions that return value 1 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:1: ERROR - @return annotation is requi red for API functions that return value
2 function badFuncNoAnnotation() { 2 function badFuncNoAnnotation() {
3 ^ 3 ^
4 4
5 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:8: ERROR - @return annotation found, y et function does not return value 5 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:8: ERROR - @return annotation found, y et function does not return value
6 function badFuncAnnotatedButNoReturn() // ERROR - no @return annotation. 6 function badFuncAnnotatedButNoReturn() // ERROR - no @return annotation.
7 ^ 7 ^
8 8
9 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:15: ERROR - @return annotation found, yet function does not return value 9 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:15: ERROR - @return annotation found, yet function does not return value
10 function badFuncAnnotatedButNoReturnValue() // ERROR - no returned value. 10 function badFuncAnnotatedButNoReturnValue() // ERROR - no returned value.
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 ^ 195 ^
196 196
197 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:121: ERROR - No __proto__ assigned for ty pe BadSetSubclass having @extends 197 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:121: ERROR - No __proto__ assigned for ty pe BadSetSubclass having @extends
198 * @extends {Set.<T>} 198 * @extends {Set.<T>}
199 ^ 199 ^
200 200
201 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:124: ERROR - Type BadSetSubclass extends Set but does not properly invoke its constructor 201 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:124: ERROR - Type BadSetSubclass extends Set but does not properly invoke its constructor
202 var BadSetSubclass = function() 202 var BadSetSubclass = function()
203 ^ 203 ^
204 204
205 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:135: ERROR - No __proto__ assigned for ty pe NS.BadSubClass having @extends
206 * @extends {Base}
207 ^
208
209 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:137: ERROR - Type NS.BadSubClass extends Base but does not properly invoke its constructor
210 NS.BadSubClass = function() {}
211 ^
212
205 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:19: ERROR - @this annotation is required f or functions referencing 'this' 213 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:19: ERROR - @this annotation is required f or functions referencing 'this'
206 function badInnerCallback() { 214 function badInnerCallback() {
207 ^ 215 ^
208 216
209 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:24: ERROR - @this annotation is required f or functions referencing 'this' 217 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:24: ERROR - @this annotation is required f or functions referencing 'this'
210 function badCallbackInCtor() { 218 function badCallbackInCtor() {
211 ^ 219 ^
212 220
213 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:54: ERROR - @this annotation is required f or functions referencing 'this' 221 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:54: ERROR - @this annotation is required f or functions referencing 'this'
214 function badCallbackInMethod() { 222 function badCallbackInMethod() {
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 ^ 331 ^
324 332
325 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:268: ERROR - @this annotation is required for functions referencing 'this' 333 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:268: ERROR - @this annotation is required for functions referencing 'this'
326 function callbackReferencingThisNotAnnotated() 334 function callbackReferencingThisNotAnnotated()
327 ^ 335 ^
328 336
329 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:277: ERROR - @this annotation found for fu nction not referencing 'this' 337 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:277: ERROR - @this annotation found for fu nction not referencing 'this'
330 function callbackNotReferencingThisAnnotated() 338 function callbackNotReferencingThisAnnotated()
331 ^ 339 ^
332 340
333 Total errors: 83 341 Total errors: 85
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698