Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: components/copresence/common/timed_map.h

Issue 419073002: Add the copresence DirectiveHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/copresence/common/timed_map.h
diff --git a/components/copresence/common/timed_map.h b/components/copresence/common/timed_map.h
new file mode 100644
index 0000000000000000000000000000000000000000..9f611c5ece67d33c07e42bc10d39bfa149650884
--- /dev/null
+++ b/components/copresence/common/timed_map.h
@@ -0,0 +1,89 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_COPRESENCE_COMMON_TIMED_MAP_
+#define COMPONENTS_COPRESENCE_COMMON_TIMED_MAP_
+
+#include <map>
+#include <queue>
+#include <vector>
+
+#include "base/macros.h"
+#include "base/time/time.h"
+#include "base/timer/timer.h"
+
+namespace copresence {
+
+// TimedMap is a map with the added functionality of clearing any
+// key/value pair after their specified lifetime is over.
Daniel Erat 2014/07/25 23:09:00 nit: s/their/its/
rkc 2014/07/28 21:01:59 Done.
+template <typename KeyType, typename ValueType>
+class TimedMap {
+ public:
+ TimedMap(const base::TimeDelta& lifetime, size_t max_elements)
+ : kEmptyValue(ValueType()),
+ lifetime_(lifetime),
+ max_elements_(max_elements) {
+ timer_.Start(FROM_HERE, lifetime_, this, &TimedMap::ClearExpiredTokens);
+ }
+
+ ~TimedMap() {}
+
+ void Add(const KeyType& key, const ValueType& value) {
+ map_[key] = value;
+ expiry_queue_.push(KeyTimeTuple(key, base::Time::Now() + lifetime_));
Daniel Erat 2014/07/25 23:09:00 make this use a base::TickClock instead of calling
rkc 2014/07/28 21:02:00 Using TimeTicks versus TimeDelta and Time seems, a
+ while (map_.size() > max_elements_)
+ ClearOldestToken();
+ }
+
+ bool HasKey(const KeyType& key) {
+ ClearExpiredTokens();
Daniel Erat 2014/07/25 23:09:01 mutating the map here and in GetValue() seems a bi
rkc 2014/07/28 21:01:59 This method returns synchronously, so even if we r
+ return map_.find(key) != map_.end();
+ }
+
+ const ValueType& GetValue(const KeyType& key) {
+ ClearExpiredTokens();
+ typename std::map<KeyType, ValueType>::const_iterator elt = map_.find(key);
+ return elt == map_.end() ? kEmptyValue : elt->second;
+ }
+
+ private:
+ void ClearExpiredTokens() {
+ while (!expiry_queue_.empty() &&
+ expiry_queue_.top().second >= base::Time::Now())
xiyuan 2014/07/25 21:02:08 Should this be "<" to trim keys whose expire time
rkc 2014/07/28 21:02:00 This is a bug, fixed. Also added unit tests. Done.
+ ClearOldestToken();
+ }
+
+ void ClearOldestToken() {
+ map_.erase(expiry_queue_.top().first);
+ expiry_queue_.pop();
+ }
+
+ typedef std::pair<KeyType, base::Time> KeyTimeTuple;
+
+ class EarliestFirstComparator {
+ public:
+ // The earlier end_time should be the 'higher' value.
xiyuan 2014/07/25 21:02:08 The comment needs to be updated. What is |end_time
Daniel Erat 2014/07/25 23:09:00 nit: s/end_time/end time/ (since i don't think thi
rkc 2014/07/28 21:01:59 Done.
rkc 2014/07/28 21:02:00 Done.
+ bool operator()(const KeyTimeTuple& left, const KeyTimeTuple& right) const {
+ return left.second > right.second;
+ }
+ };
+
+ typedef std::priority_queue<KeyTimeTuple,
+ std::vector<KeyTimeTuple>,
Daniel Erat 2014/07/25 23:09:01 can you unwrap this? it should fit on the end of t
rkc 2014/07/28 21:02:00 Done, though git cl format will probably break thi
+ EarliestFirstComparator> ExpiryQueue;
+
+ const ValueType kEmptyValue;
xiyuan 2014/07/25 21:02:08 Can we make this a "static" member? Carrying one w
rkc 2014/07/28 21:01:59 Can't have global or static const objects in Chrom
+
+ base::RepeatingTimer<TimedMap> timer_;
+ const base::TimeDelta lifetime_;
+ const size_t max_elements_;
+ std::map<KeyType, ValueType> map_;
+ ExpiryQueue expiry_queue_;
Daniel Erat 2014/07/25 23:09:01 add a comment documenting what this contains
rkc 2014/07/28 21:02:00 Done.
+
+ DISALLOW_COPY_AND_ASSIGN(TimedMap);
+};
+
+} // namespace copresence
+
+#endif // COMPONENTS_COPRESENCE_COMMON_TIMED_MAP_

Powered by Google App Engine
This is Rietveld 408576698