Add the copresence DirectiveHandler.

components/copresence/timed_map_unittest.cc

Index: components/copresence/timed_map_unittest.cc
diff --git a/components/copresence/timed_map_unittest.cc b/components/copresence/timed_map_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b68309456593087c58ddaddf6f5a7b18d1c1ee88
--- /dev/null
+++ b/components/copresence/timed_map_unittest.cc
@@ -0,0 +1,96 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/basictypes.h"
+#include "base/macros.h"
+#include "base/message_loop/message_loop.h"
+#include "components/copresence/timed_map.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+struct Value {
+  Value() : value(0) {}
+  explicit Value(int new_value) : value(new_value) {}
+
+  int value;
+};
+
+}  // namespace
+
+class TimedMapTest : public testing::Test {

[Daniel Erat, 2014/07/31 22:31:16]

please add tests that test the "timed" part of this class. the reason for my
suggestion to use TickClock was so that you can have tests that provide their
own implementation so that the timing-related part of this class can be tested;
hardcoding DefaultTickClock into the implementation doesn't accomplish anything.

[rkc, 2014/08/01 21:08:57]

Done.

+ public:
+  TimedMapTest() {}
+
+ private:
+  // Exists since the timer needs a message loop.
+  base::MessageLoop message_loop_;
+
+  DISALLOW_COPY_AND_ASSIGN(TimedMapTest);
+};
+
+TEST_F(TimedMapTest, Basic) {
+  typedef copresence::TimedMap<int, Value> Map;
+  Map map(base::TimeDelta::FromSeconds(0x7331), 3);

[Daniel Erat, 2014/07/31 22:31:16]

why are you passing the seconds as hex?

[rkc, 2014/08/01 21:08:57]

Just wanted a random large value, didn't think it would matter what form I
provided the value in :) Changed to decimal for easier readability.
Done.

+
+  EXPECT_FALSE(map.HasKey(0));
+  EXPECT_EQ(0, map.GetValue(0).value);
+
+  map.Add(0x1337, Value(0x7331));
+  EXPECT_TRUE(map.HasKey(0x1337));
+  EXPECT_EQ(0x7331, map.GetValue(0x1337).value);
+
+  map.Add(0xbaad, Value(0xf00d));
+  EXPECT_TRUE(map.HasKey(0xbaad));
+  EXPECT_EQ(0xf00d, map.GetValue(0xbaad).value);
+  EXPECT_EQ(0x7331, map.GetValue(0x1337).value);
+
+  map.Add(0x1234, Value(0x5678));
+  EXPECT_TRUE(map.HasKey(0x1234));
+  EXPECT_TRUE(map.HasKey(0xbaad));
+  EXPECT_TRUE(map.HasKey(0x1337));
+
+  EXPECT_EQ(0x5678, map.GetValue(0x1234).value);
+  EXPECT_EQ(0xf00d, map.GetValue(0xbaad).value);
+  EXPECT_EQ(0x7331, map.GetValue(0x1337).value);
+}
+
+TEST_F(TimedMapTest, ValueReplacement) {
+  typedef copresence::TimedMap<int, Value> Map;
+  Map map(base::TimeDelta::FromSeconds(0x7331), 10);
+
+  map.Add(0x1337, Value(0x7331));
+  EXPECT_TRUE(map.HasKey(0x1337));
+  EXPECT_EQ(0x7331, map.GetValue(0x1337).value);
+
+  map.Add(0xbaad, Value(0xf00d));
+  EXPECT_TRUE(map.HasKey(0xbaad));
+  EXPECT_EQ(0xf00d, map.GetValue(0xbaad).value);
+
+  map.Add(0x1337, Value(0xd00d));
+  EXPECT_TRUE(map.HasKey(0x1337));
+  EXPECT_EQ(0xd00d, map.GetValue(0x1337).value);
+}
+
+TEST_F(TimedMapTest, SizeEvict) {
+  typedef copresence::TimedMap<int, Value> Map;
+  Map two_element_map(base::TimeDelta::FromSeconds(0x7331), 2);
+
+  two_element_map.Add(0x1337, Value(0x7331));
+  EXPECT_TRUE(two_element_map.HasKey(0x1337));
+  EXPECT_EQ(0x7331, two_element_map.GetValue(0x1337).value);
+
+  two_element_map.Add(0xbaad, Value(0xf00d));
+  EXPECT_TRUE(two_element_map.HasKey(0xbaad));
+  EXPECT_EQ(0xf00d, two_element_map.GetValue(0xbaad).value);
+
+  two_element_map.Add(0x1234, Value(0x5678));
+  EXPECT_TRUE(two_element_map.HasKey(0x1234));
+  EXPECT_EQ(0xf00d, two_element_map.GetValue(0xbaad).value);
+
+  EXPECT_FALSE(two_element_map.HasKey(0x1337));
+  EXPECT_EQ(0, two_element_map.GetValue(0x1337).value);
+}
+
+// TODO(rkc): Figure out how to test timed eviction and add a TimedEvict test.