components/copresence/proto/codes.proto - Issue 419073002: Add the copresence DirectiveHandler.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/copresence/proto/codes.proto

Issue 419073002: Add the copresence DirectiveHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« components/copresence/mediums/audio/audio_recorder.cc ('K') | « components/copresence/mediums/audio/audio_recorder_unittest.cc ('k') | components/copresence/proto/data.proto » ('j') | components/copresence/proto/data.proto » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 syntax = "proto2";
	xiyuan 2014/07/25 21:02:10 nit: Do we have style guild for proto buf definiti nit: Do we have style guild for proto buf definition? The file looks a bit crowded. Let's add a few empty lines to break it up into sections. rkc 2014/07/28 21:02:03 These files are auto-generated using Google3 tools Show quoted text On 2014/07/25 21:02:10, xiyuan wrote: > nit: Do we have style guild for proto buf definition? The file looks a bit > crowded. Let's add a few empty lines to break it up into sections. These files are auto-generated using Google3 tools. Any style changes we make will be lost at the next revision.
	2 package util.error;

	3 option optimize_for = LITE_RUNTIME;

	4 enum Code {
	Daniel Erat 2014/07/28 21:18:19 why isn't this in enums.proto? why isn't this in enums.proto? rkc 2014/07/29 00:33:36 This isn't code we control, this is pulled from Go Show quoted text On 2014/07/28 21:18:19, Daniel Erat wrote: > why isn't this in enums.proto? This isn't code we control, this is pulled from Google3 directly. I'll ask the server folks to look into it.
	5 OK = 0;
	Daniel Erat 2014/07/28 21:18:19 are these all documented somewhere else? are these all documented somewhere else? rkc 2014/07/29 00:33:36 In the original protos on Google3. Show quoted text On 2014/07/28 21:18:19, Daniel Erat wrote: > are these all documented somewhere else? In the original protos on Google3.
	6 CANCELLED = 1;

	7 UNKNOWN = 2;

	8 INVALID_ARGUMENT = 3;

	9 DEADLINE_EXCEEDED = 4;

	10 NOT_FOUND = 5;

	11 ALREADY_EXISTS = 6;

	12 PERMISSION_DENIED = 7;

	13 UNAUTHENTICATED = 16;

	14 RESOURCE_EXHAUSTED = 8;

	15 FAILED_PRECONDITION = 9;

	16 ABORTED = 10;

	17 OUT_OF_RANGE = 11;

	18 UNIMPLEMENTED = 12;

	19 INTERNAL = 13;

	20 UNAVAILABLE = 14;

	21 DATA_LOSS = 15;

	22 DO_NOT_USE_RESERVED_FOR_FUTURE_EXPANSION_USE_DEFAULT_IN_SWITCH_INSTEAD_ = 20;

	23 }

OLD	NEW