components/copresence/common/copresence_constants.h - Issue 419073002: Add the copresence DirectiveHandler.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/copresence/common/copresence_constants.h

Issue 419073002: Add the copresence DirectiveHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_COPRESENCE_COMMON_COPRESENCE_CONSTANTS_

	6 #define COMPONENTS_COPRESENCE_COMMON_COPRESENCE_CONSTANTS_

	7

	8 #include "media/base/channel_layout.h"

	9

	10 namespace copresence {

	11

	12 extern const int kDefaultRepetitions;
	Daniel Erat 2014/07/25 23:09:00 nit: add a brief comment documenting what each of nit: add a brief comment documenting what each of these is used for (or better, make them be public static members of the classes that they're most closely associated with if possible) rkc 2014/07/28 21:01:59 We eventually want to make these values configurab Show quoted text On 2014/07/25 23:09:00, Daniel Erat wrote: > nit: add a brief comment documenting what each of these is used for (or better, > make them be public static members of the classes that they're most closely > associated with if possible) We eventually want to make these values configurable, in which case I'll remove them from here. Added a TODO and detailed comments for each field.
	13 extern const float kDefaultSampleRate;

	14 extern const int kDefaultBitsPerSample;

	15 extern const float kDefaultCarrierFrequency;

	16 extern const int kDefaultChannels;

	17 extern const media::ChannelLayout kDefaultChannelLayout;

	18

	19 } // namespace copresence

	20

	21 #endif // COMPONENTS_COPRESENCE_COMMON_COPRESENCE_CONSTANTS_

OLD	NEW