Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 419063004: Files.app: Move the position of dummy element for measuring the size of text. (Closed)

Created:
6 years, 5 months ago by hirono
Modified:
6 years, 5 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Files.app: Move the position of dummy element for measuring the size of text. BUG=392981 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285536

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -15 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 2 chunks +9 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/text_measure.js View 1 1 chunk +18 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hirono
PTAL the CL? Thanks!
6 years, 5 months ago (2014-07-25 04:10:13 UTC) #1
yoshiki
lgtm with nit https://codereview.chromium.org/419063004/diff/1/ui/file_manager/file_manager/foreground/js/text_measure.js File ui/file_manager/file_manager/foreground/js/text_measure.js (right): https://codereview.chromium.org/419063004/diff/1/ui/file_manager/file_manager/foreground/js/text_measure.js#newcode35 ui/file_manager/file_manager/foreground/js/text_measure.js:35: TextMeasure.COPIED_STYLE = Object.seal([ nit: STYLES_TO_BE_COPYED is ...
6 years, 5 months ago (2014-07-25 04:25:44 UTC) #2
hirono
Thank you! https://codereview.chromium.org/419063004/diff/1/ui/file_manager/file_manager/foreground/js/text_measure.js File ui/file_manager/file_manager/foreground/js/text_measure.js (right): https://codereview.chromium.org/419063004/diff/1/ui/file_manager/file_manager/foreground/js/text_measure.js#newcode35 ui/file_manager/file_manager/foreground/js/text_measure.js:35: TextMeasure.COPIED_STYLE = Object.seal([ On 2014/07/25 04:25:44, yoshiki ...
6 years, 5 months ago (2014-07-25 04:31:46 UTC) #3
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 5 months ago (2014-07-25 07:41:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/419063004/20001
6 years, 5 months ago (2014-07-25 07:41:55 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 08:59:03 UTC) #6
Message was sent while issue was closed. 
Change committed as 285536

Powered by Google App Engine
This is Rietveld 408576698