Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h - Issue 419053005: Fix crash in HTMLInputElement::setupDateTimeChooserParameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h

Issue 419053005: Fix crash in HTMLInputElement::setupDateTimeChooserParameters (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address issues Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/calendar-picker/datepicker-crash-after-keydown.html ('K') | « Source/core/html/HTMLInputElement.cpp ('k') | Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h

diff --git a/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h b/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h

index c8a7e812795597f46c692508778a20c556007901..5d0a2bbb808aa2a97ac32499c41d1a1f9785f730 100644

--- a/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h

+++ b/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h

@@ -115,6 +115,7 @@ private:

virtual void valueAttributeChanged() OVERRIDE;

virtual void listAttributeTargetChanged() OVERRIDE FINAL;

virtual void updateClearButtonVisibility() OVERRIDE FINAL;

+ virtual TextDirection computedTextDirection() OVERRIDE FINAL;

DateTimeEditElement* dateTimeEditElement() const;

SpinButtonElement* spinButtonElement() const;