Source/core/html/HTMLInputElement.cpp - Issue 419053005: Fix crash in HTMLInputElement::setupDateTimeChooserParameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 419053005: Fix crash in HTMLInputElement::setupDateTimeChooserParameters (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/datepicker-crash-after-keydown.html ('K') | « LayoutTests/fast/forms/datepicker-crash-after-keydown-expected.txt ('k') | Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h » ('j') | Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLInputElement.cpp

diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp

index 1cb6779a02a95296de74a5bc614f9b5e5b87e8d9..eac55fc56cef4d23d92e75f9c45a026bbe0161e7 100644

--- a/Source/core/html/HTMLInputElement.cpp

+++ b/Source/core/html/HTMLInputElement.cpp

@@ -1828,7 +1828,7 @@ bool HTMLInputElement::setupDateTimeChooserParameters(DateTimeChooserParameters&

parameters.anchorRectInRootView = document().view()->contentsToRootView(pixelSnappedBoundingBox());

parameters.currentValue = value();

parameters.doubleValue = m_inputType->valueAsDouble();

- parameters.isAnchorElementRTL = computedStyle()->direction() == RTL;

+ parameters.isAnchorElementRTL = m_inputType->computedTextDirection() == RTL;

if (HTMLDataListElement* dataList = this->dataList()) {

RefPtrWillBeRawPtr<HTMLCollection> options = dataList->options();

for (unsigned i = 0; HTMLOptionElement* option = toHTMLOptionElement(options->item(i)); ++i) {