Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: ppapi/BUILD.gn

Issue 419053002: Miscellaneous GN updates. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/BUILD.gn
diff --git a/ppapi/BUILD.gn b/ppapi/BUILD.gn
index 0433407f6607dac50e2087dbbf1af50cde1ecec6..af9e02ec66c892bc52cf92a028733e03744f0dcf 100644
--- a/ppapi/BUILD.gn
+++ b/ppapi/BUILD.gn
@@ -12,7 +12,7 @@ gypi_values = exec_script(
#if (chrome_multiple_dll) {
# blink_target = "//third_party/WebKit/public:blink_minimal"
#} else {
-# blink_target = "//third_party/WebKit/public:blink"
+ blink_target = "//third_party/WebKit/public:blink"
#}
# These are just headers.
@@ -404,7 +404,7 @@ component("ppapi_shared") {
"//gpu/command_buffer/client:gles2_implementation",
"//gpu/command_buffer/common",
"//ipc",
- #"//media:shared_memory_support", TODO(GYP)
+ "//media:shared_memory_support",
"//skia",
"//third_party/icu:icuuc",
"//ui/surface",
@@ -417,9 +417,8 @@ component("ppapi_shared") {
cflags = [ "/wd4267" ] # size_t to int truncation.
}
- # TODO(GYP)
- #deps += [ blink_target ]
- #forward_dependent_configs_from = [ blink_target ]
+ deps += [ blink_target ]
+ forward_dependent_configs_from = [ blink_target ]
}
source_set("ppapi_ipc") {
@@ -722,12 +721,12 @@ component("ppapi_proxy") {
"//base/third_party/dynamic_annotations",
"//gpu/command_buffer/client:gles2_implementation",
"//gpu/ipc",
- #"//media:shared_memory_support", # TODO(GYP)
+ "//media:shared_memory_support",
"//ipc",
"//skia",
"//third_party/icu",
"//ui/surface",
- #blink_target, TODO(GYP)
+ blink_target,
]
if (is_win) {
@@ -767,9 +766,9 @@ component("ppapi_host") {
":ppapi_shared",
"//base",
"//ipc",
+ "//media:shared_memory_support",
"//ui/surface",
"//url",
- #'../media/media.gyp:shared_memory_support', TODO(GYP)
]
}
« no previous file with comments | « gpu/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698