Issue 419053002: Miscellaneous GN updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 419053002: Miscellaneous GN updates. (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, piman+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Miscellaneous GN updates. Removes some unnecessary prints accidentally checked in to the Android build. Removes a GYP TODO now that angle has rolled. Updates commented-out labels of targets that now exist. R=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285400

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -49 lines)			Patch
M	ash/BUILD.gn	View	10 chunks	+10 lines, -10 lines	0 comments	Download
M	build/config/android/rules.gni	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/BUILD.gn	View	10 chunks	+23 lines, -21 lines	0 comments	Download
M	chrome/utility/BUILD.gn	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	gpu/BUILD.gn	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ppapi/BUILD.gn	View	5 chunks	+7 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r285400.