Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 419033012: Roll WebGL conformance tests to 2cd3af21 (Closed)

Created:
6 years, 4 months ago by oetuaho-nv
Modified:
6 years, 4 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Project:
chromium
Visibility:
Public.

Description

Roll WebGL conformance tests to 2cd3af21 BUG=398337 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288055

Patch Set 1 #

Patch Set 2 : Add failures seen on bots #

Total comments: 3

Patch Set 3 : Add bug numbers and sort failures correctly #

Patch Set 4 : Fix lines above 80 chars in webgl_conformance_expectations.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 2 3 6 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
oetuaho-nv
Here's the WebGL roll. I included the OS information from the bots in the failures ...
6 years, 4 months ago (2014-07-31 14:23:23 UTC) #1
Zhenyao Mo
https://codereview.chromium.org/419033012/diff/20001/content/test/gpu/gpu_tests/webgl_conformance_expectations.py File content/test/gpu/gpu_tests/webgl_conformance_expectations.py (right): https://codereview.chromium.org/419033012/diff/20001/content/test/gpu/gpu_tests/webgl_conformance_expectations.py#newcode30 content/test/gpu/gpu_tests/webgl_conformance_expectations.py:30: self.Fail('conformance/glsl/misc/shaders-with-uniform-structs.html') Could you remove the failing tests above (shaders-with-mis-matching-uniforms.html) ...
6 years, 4 months ago (2014-07-31 19:48:28 UTC) #2
Zhenyao Mo
On 2014/07/31 14:23:23, oetuaho-nv wrote: > Here's the WebGL roll. I included the OS information ...
6 years, 4 months ago (2014-07-31 19:51:00 UTC) #3
oetuaho-nv
Patch set 3 addresses the review comments. I'll keep an eye on the GPU bots ...
6 years, 4 months ago (2014-08-01 09:17:03 UTC) #4
oetuaho-nv
Zhenyao, could you review the updated patch?
6 years, 4 months ago (2014-08-05 09:22:15 UTC) #5
Zhenyao Mo
LGTM Thank you.
6 years, 4 months ago (2014-08-06 19:02:40 UTC) #6
oetuaho-nv
The CQ bit was checked by oetuaho@nvidia.com
6 years, 4 months ago (2014-08-07 07:46:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oetuaho@nvidia.com/419033012/40001
6 years, 4 months ago (2014-08-07 07:48:28 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-07 10:43:45 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 10:47:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/2582)
6 years, 4 months ago (2014-08-07 10:47:07 UTC) #11
oetuaho-nv
The CQ bit was unchecked by oetuaho@nvidia.com
6 years, 4 months ago (2014-08-07 11:14:49 UTC) #12
oetuaho-nv
The CQ bit was checked by oetuaho@nvidia.com
6 years, 4 months ago (2014-08-07 11:14:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oetuaho@nvidia.com/419033012/60001
6 years, 4 months ago (2014-08-07 11:16:12 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 15:53:20 UTC) #15
Message was sent while issue was closed.
Change committed as 288055

Powered by Google App Engine
This is Rietveld 408576698