Issue 419033007: Limit the window of time a promo can be visible after first view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 419033007: Limit the window of time a promo can be visible after first view. (Closed)

Created:
6 years, 5 months ago by justincohen

Modified:
6 years, 5 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Limit the window of time a promo can be visible after first view. Notification promos currently have start, end times, and a number of maximum views. However, the length of time a promo can be visible was not capped. This change adds a flag to cap the length of time a promo is visible by max_seconds_. BUG=None Test=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285803

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -1 line)			Patch
	M	chrome/browser/web_resource/notification_promo.h	View		2 chunks	+11 lines, -0 lines	0 comments	Download
	M	chrome/browser/web_resource/notification_promo.cc	View		8 chunks	+25 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

This seems reasonable. LGTM. You also need to add the field to the server, though.

6 years, 5 months ago (2014-07-25 17:52:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/419033007/1

6 years, 5 months ago (2014-07-26 12:03:53 UTC) #4

Message was sent while issue was closed.

Change committed as 285803

Expand Messages | Collapse Messages