Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 419033002: Remove some setHasCustomStyleCallbacks calls (Closed)

Created:
6 years, 5 months ago by rwlbuis
Modified:
6 years, 4 months ago
Reviewers:
pdr., adamk
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove some setHasCustomStyleCallbacks calls These calls do nothing and in fact cause extra cycles in Element::styleForRenderer(). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179063

Patch Set 1 #

Patch Set 2 : V2 #

Patch Set 3 : V3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/core/html/HTMLSelectElement.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLTitleElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
rwlbuis
PTAL
6 years, 5 months ago (2014-07-25 14:59:45 UTC) #1
adamk
lgtm Would be nice if we could somehow catch these with ASSERTs, but it looks ...
6 years, 4 months ago (2014-07-28 18:39:55 UTC) #2
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 4 months ago (2014-07-28 18:44:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/419033002/60001
6 years, 4 months ago (2014-07-28 18:45:17 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-07-28 18:46:52 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-28 18:47:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/5292) blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/11263)
6 years, 4 months ago (2014-07-28 18:47:01 UTC) #7
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 4 months ago (2014-07-28 19:31:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/419033002/60001
6 years, 4 months ago (2014-07-28 19:32:28 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-07-28 20:39:38 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-28 20:54:09 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/39095)
6 years, 4 months ago (2014-07-28 20:54:09 UTC) #12
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 4 months ago (2014-07-28 22:47:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/419033002/60001
6 years, 4 months ago (2014-07-28 22:47:47 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 23:12:52 UTC) #15
Message was sent while issue was closed.
Change committed as 179063

Powered by Google App Engine
This is Rietveld 408576698