Autocomplete confused about direction if inline style and inherited dir attribute are mixed

Source/core/html/HTMLTextFormControlElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 13 matching lines @@
 
 #include "config.h"
 #include "core/html/HTMLTextFormControlElement.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
 #include "core/HTMLNames.h"
 #include "core/accessibility/AXObjectCache.h"
 #include "core/dom/Document.h"
 #include "core/dom/NodeList.h"
+#include "core/dom/NodeRenderStyle.h"
 #include "core/dom/NodeTraversal.h"
 #include "core/dom/Text.h"
 #include "core/dom/shadow/ShadowRoot.h"
 #include "core/editing/Editor.h"
 #include "core/editing/FrameSelection.h"
 #include "core/editing/TextIterator.h"
 #include "core/editing/htmlediting.h"
 #include "core/events/Event.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/UseCounter.h"
@@ skipping 679 matching lines @@
         if (equalIgnoringCase(dirAttributeValue, "auto")) {
             bool isAuto;
             TextDirection textDirection = element->directionalityIfhasDirAutoAttribute(isAuto);
             return textDirection == RTL ? "rtl" : "ltr";
         }
     }
 
     return "ltr";
 }
 
+String HTMLTextFormControlElement::directionForAutocomplete() const

[tkent, 2014/08/07 05:25:02]

You don't need to add new function.
Please replace the content of WebFormControlElement::directionForFormData with
this code.

[Sunil Ratnu, 2014/08/07 07:06:18]

Done.

+{
+    if (const HTMLElement* element = this) {

[tkent, 2014/08/07 05:25:02]

|this| must not be null.

[Sunil Ratnu, 2014/08/07 07:06:18]

|this| can not be NULL here. What i understood it that you wanted to point that
the check here might not be necessary?

[tkent, 2014/08/07 07:13:46]

Right. The check is unnecessary.

+        if (RenderStyle* style = element->renderStyle())
+            return style->isLeftToRightDirection() ? "ltr" : "rtl";
+    }
+    return "ltr";
+}
+
 HTMLElement* HTMLTextFormControlElement::innerEditorElement() const
 {
     return toHTMLElement(userAgentShadowRoot()->getElementById(ShadowElementNames::innerEditor()));
 }
 
 static Position innerNodePosition(const Position& innerPosition)
 {
     ASSERT(innerPosition.anchorType() != Position::PositionIsBeforeAnchor);
     ASSERT(innerPosition.anchorType() != Position::PositionIsAfterAnchor);
     HTMLElement* element = toHTMLElement(innerPosition.anchorNode());
@@ skipping 225 matching lines @@
             Text* textNode = toText(node);
             size_t firstLineBreak = textNode->data().find('\n', isPivotNode ? pivotPosition.offsetInContainerNode() : 0);
             if (firstLineBreak != kNotFound)
                 return Position(textNode, firstLineBreak + 1);
         }
     }
     return endOfInnerText(textFormControl);
 }
 
 } // namespace Webcore