Autocomplete confused about direction if inline style and inherited dir attribute are mixed

Source/core/html/HTMLTextFormControlElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 13 matching lines @@
 
 #include "config.h"
 #include "core/html/HTMLTextFormControlElement.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
 #include "core/HTMLNames.h"
 #include "core/accessibility/AXObjectCache.h"
 #include "core/dom/Document.h"
 #include "core/dom/NodeList.h"
+#include "core/dom/NodeRenderStyle.h"
 #include "core/dom/NodeTraversal.h"
 #include "core/dom/Text.h"
 #include "core/dom/shadow/ShadowRoot.h"
 #include "core/editing/Editor.h"
 #include "core/editing/FrameSelection.h"
 #include "core/editing/TextIterator.h"
 #include "core/events/Event.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/UseCounter.h"
 #include "core/html/HTMLBRElement.h"
@@ skipping 605 matching lines @@
         element = element->parentElement();
         if (element && element->isHTMLElement())
             return toHTMLElement(element);
     }
     return 0;
 }
 
 String HTMLTextFormControlElement::directionForFormData() const
 {
     for (const HTMLElement* element = this; element; element = parentHTMLElement(element)) {
-        const AtomicString& dirAttributeValue = element->fastGetAttribute(dirAttr);
-        if (dirAttributeValue.isNull())
-            continue;
-
-        if (equalIgnoringCase(dirAttributeValue, "rtl") || equalIgnoringCase(dirAttributeValue, "ltr"))
-            return dirAttributeValue;
-
-        if (equalIgnoringCase(dirAttributeValue, "auto")) {
-            bool isAuto;
-            TextDirection textDirection = element->directionalityIfhasDirAutoAttribute(isAuto);
-            return textDirection == RTL ? "rtl" : "ltr";
+        RenderStyle* style = element->renderStyle();
+        if (style) {

[Inactive, 2014/08/06 20:51:43]

I cannot say if the change is good or not. However, style-wise, this could be
written as:
if (RenderStyle* style = element->renderStyle())
    return style->isLeftToRightDirection() ? "ltr" : "rtl";

[Sunil Ratnu, 2014/08/07 05:20:56]

Done.

+            return style->isLeftToRightDirection() ? "ltr" : "rtl";
         }
     }
 
     return "ltr";
 }
 
 HTMLElement* HTMLTextFormControlElement::innerEditorElement() const
 {
     return toHTMLElement(userAgentShadowRoot()->getElementById(ShadowElementNames::innerEditor()));
 }
@@ skipping 231 matching lines @@
             Text* textNode = toText(node);
             size_t firstLineBreak = textNode->data().find('\n', isPivotNode ? pivotPosition.offsetInContainerNode() : 0);
             if (firstLineBreak != kNotFound)
                 return Position(textNode, firstLineBreak + 1);
         }
     }
     return endOfInnerText(textFormControl);
 }
 
 } // namespace Webcore