Autocomplete confused about direction if inline style and inherited dir attribute are mixed

Source/web/WebFormControlElement.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "public/web/WebFormControlElement.h"
 
+#include "core/dom/NodeRenderStyle.h"
 #include "core/html/HTMLFormControlElement.h"
 #include "core/html/HTMLFormElement.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLSelectElement.h"
 #include "core/html/HTMLTextAreaElement.h"
 
 #include "wtf/PassRefPtr.h"
 
 using namespace blink;
 
@@ skipping 120 matching lines @@
 {
     if (isHTMLInputElement(*m_private))
         return constUnwrap<HTMLInputElement>()->selectionEnd();
     if (isHTMLTextAreaElement(*m_private))
         return constUnwrap<HTMLTextAreaElement>()->selectionEnd();
     return 0;
 }
 
 WebString WebFormControlElement::directionForFormData() const
 {
-    if (isHTMLInputElement(*m_private))
-        return constUnwrap<HTMLInputElement>()->directionForFormData();
-    if (isHTMLTextAreaElement(*m_private))
-        return constUnwrap<HTMLTextAreaElement>()->directionForFormData();
-    return WebString();
+    if (isHTMLInputElement(*m_private)) {

[Sunil Ratnu, 2014/08/07 07:06:18]

Can we have it like this as well?

if (RenderStyle* style =
constUnwrap<HTMLTextFormControlElement>()->renderStyle())
    return style->isLeftToRightDirection() ? "ltr" : "rtl";
return "ltr";

[tkent, 2014/08/07 07:13:46]

No.  It doesn't work if m_private is not HTMLTextFormControlElement.

Instead, constUnwrap<HTMLFormControlElement>()->renderStyle() will work.  It's
ok to return the direction of form controls other than INPUT/TEXTAREA.

+        if (RenderStyle* style = constUnwrap<HTMLInputElement>()->renderStyle())
+            return style->isLeftToRightDirection() ? "ltr" : "rtl";
+    }
+    if (isHTMLTextAreaElement(*m_private)) {
+        if (RenderStyle* style = constUnwrap<HTMLTextAreaElement>()->renderStyle())
+            return style->isLeftToRightDirection() ? "ltr" : "rtl";
+    }
+    return "ltr";
 }
 
 bool WebFormControlElement::isActivatedSubmit() const
 {
     return constUnwrap<HTMLFormControlElement>()->isActivatedSubmit();
 }
 
 WebFormElement WebFormControlElement::form() const
 {
     return WebFormElement(constUnwrap<HTMLFormControlElement>()->form());
 }
 
 WebFormControlElement::WebFormControlElement(const PassRefPtrWillBeRawPtr<HTMLFormControlElement>& elem)
     : WebElement(elem)
 {
 }
 
 WebFormControlElement& WebFormControlElement::operator=(const PassRefPtrWillBeRawPtr<HTMLFormControlElement>& elem)
 {
     m_private = elem;
     return *this;
 }
 
 WebFormControlElement::operator PassRefPtrWillBeRawPtr<HTMLFormControlElement>() const
 {
     return toHTMLFormControlElement(m_private.get());
 }
 
 } // namespace blink