chrome/browser/ui/views/toolbar/toolbar_view.cc - Issue 419023002: Move ShowPopup logic from BrowserActionsContainer to BrowserActionView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_view.cc

Issue 419023002: Move ShowPopup logic from BrowserActionsContainer to BrowserActionView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/toolbar/toolbar_view.cc

diff --git a/chrome/browser/ui/views/toolbar/toolbar_view.cc b/chrome/browser/ui/views/toolbar/toolbar_view.cc

index ae496b6aa1c0565ace60b32687ffa3c10a5df16b..05749038b30320a9e5821da5a94f42ec542ad9b0 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_view.cc

+++ b/chrome/browser/ui/views/toolbar/toolbar_view.cc

@@ -338,7 +338,7 @@ void ToolbarView::ShowPageActionPopup(const extensions::Extension* extension) {

void ToolbarView::ShowBrowserActionPopup(

const extensions::Extension* extension) {

- browser_actions_->ShowPopup(extension, true);

+ browser_actions_->ShowPopupForExtension(extension, true, false);

}

void ToolbarView::ShowAppMenu(bool for_drop) {

« no previous file with comments | « chrome/browser/ui/views/toolbar/browser_actions_container.cc ('k') | no next file » | no next file with comments »