Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4575)

Unified Diff: chrome/browser/certificate_manager_model.h

Issue 419013003: Replace c/b/nss_context by a KeyedService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Separated out ClientCertStoreChromeOS change. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/certificate_manager_model.h
diff --git a/chrome/browser/certificate_manager_model.h b/chrome/browser/certificate_manager_model.h
index 34d0f0786f29b2491e918d725508f12be2c90234..53fba491836155fecb0b67946ecf18f16ef66ef7 100644
--- a/chrome/browser/certificate_manager_model.h
+++ b/chrome/browser/certificate_manager_model.h
@@ -11,9 +11,14 @@
#include "base/callback.h"
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
#include "base/strings/string16.h"
#include "net/cert/nss_cert_database.h"
+namespace cert_database {
+class CertDatabaseServiceIOPart;
+}
stevenjb 2014/10/29 18:43:51 // namespace cert_database (for consistency with c
Lei Zhang 2014/10/29 21:51:40 IMO there's no need when then the namespace block
pneubeck (no reviews) 2014/11/05 14:53:36 I think it's more common to drop the namespace com
+
namespace content {
class BrowserContext;
class ResourceContext;
@@ -141,9 +146,11 @@ class CertificateManagerModel {
CertificateManagerModel::Observer* observer,
const CreationCallback& callback,
net::NSSCertDatabase* cert_db);
- static void GetCertDBOnIOThread(content::ResourceContext* context,
- CertificateManagerModel::Observer* observer,
- const CreationCallback& callback);
+ static void GetCertDBOnIOThread(
+ base::WeakPtr<cert_database::CertDatabaseServiceIOPart>
+ cert_db_service_io,
+ CertificateManagerModel::Observer* observer,
+ const CreationCallback& callback);
// Callback used by Refresh() for when the cert slots have been unlocked.
// This method does the actual refreshing.

Powered by Google App Engine
This is Rietveld 408576698