Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 418983002: Nukes view_manager namespace (Closed)

Created:
6 years, 5 months ago by sky
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Nukes view_manager namespace BUG=none TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285361

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : resolve merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -407 lines) Patch
M mojo/aura/window_tree_host_mojo.h View 1 2 chunks +5 lines, -6 lines 0 comments Download
M mojo/aura/window_tree_host_mojo.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/examples/aura_demo/aura_demo.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M mojo/examples/aura_demo/view_manager_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/browser/browser.cc View 8 chunks +16 lines, -17 lines 0 comments Download
M mojo/examples/demo_launcher/demo_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/embedded_app/embedded_app.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M mojo/examples/keyboard/keyboard.cc View 5 chunks +8 lines, -11 lines 0 comments Download
M mojo/examples/media_viewer/media_viewer.cc View 7 chunks +17 lines, -18 lines 0 comments Download
M mojo/examples/nesting_app/nesting_app.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M mojo/examples/png_viewer/png_viewer.cc View 6 chunks +14 lines, -15 lines 0 comments Download
M mojo/examples/window_manager/debug_panel.h View 3 chunks +2 lines, -4 lines 0 comments Download
M mojo/examples/window_manager/debug_panel.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/window_manager/window_manager.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M mojo/examples/wm_flow/app/app.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M mojo/examples/wm_flow/init/init.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/wm_flow/wm/wm.cc View 2 chunks +14 lines, -14 lines 0 comments Download
M mojo/services/html_viewer/html_document_view.h View 2 chunks +10 lines, -13 lines 0 comments Download
M mojo/services/html_viewer/html_document_view.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/services/html_viewer/html_viewer.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/node.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/node_observer.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/node_private.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/node_private.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_factory.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_test_suite.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_test_suite.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_private.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_private.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/node.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/node_observer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/node_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/types.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/util.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_manager.h View 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_manager_client_factory.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_manager_delegate.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_observer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/window_manager_delegate.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager_constants.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/context_factory_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/context_factory_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/ids.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/main.cc View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/services/view_manager/node.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/node.cc View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/services/view_manager/node_delegate.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/root_view_manager.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/root_view_manager.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/root_view_manager_delegate.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/screen_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/screen_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/view.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/view.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/view_manager_init_service_context.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/view_manager_init_service_context.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/view_manager_init_service_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/view_manager_init_service_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/window_tree_host_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/window_tree_host_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/window_manager/window_manager_api_unittest.cc View 11 chunks +35 lines, -35 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.h View 3 chunks +22 lines, -22 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.cc View 7 chunks +24 lines, -24 lines 0 comments Download
M mojo/services/window_manager/window_manager_service_impl.h View 1 1 chunk +7 lines, -10 lines 0 comments Download
M mojo/services/window_manager/window_manager_service_impl.cc View 6 chunks +11 lines, -13 lines 0 comments Download
M mojo/shell/view_manager_loader.h View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/shell/view_manager_loader.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/views/native_widget_view_manager.h View 1 3 chunks +14 lines, -15 lines 0 comments Download
M mojo/views/native_widget_view_manager.cc View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
6 years, 5 months ago (2014-07-24 20:30:00 UTC) #1
Ben Goodger (Google)
Rubber stamp LGTM
6 years, 5 months ago (2014-07-24 20:30:54 UTC) #2
sky
6 years, 5 months ago (2014-07-24 20:42:33 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 manually as r285361 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698