Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 418883003: Roll trace-viewer to latest and update telemetry accordingly (Closed)

Created:
6 years, 5 months ago by nduca
Modified:
6 years, 4 months ago
Reviewers:
dsinclair, dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

This pulls in trace-viewer, which has switched to html imports As such, update telemery to html imports as well. TBR=dtu,dsinclair Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285874

Patch Set 1 #

Patch Set 2 : with_newer_rev #

Patch Set 3 : try 2 #

Patch Set 4 : r1411 #

Patch Set 5 : r1412 to pick up error messages that happen on browser startup #

Patch Set 6 : one more go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -108 lines) Patch
M DEPS View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/web_components/results_viewer.html View 2 chunks +9 lines, -6 lines 0 comments Download
D tools/telemetry/telemetry/web_components/results_viewer.js View 1 chunk +0 lines, -39 lines 0 comments Download
A tools/telemetry/telemetry/web_components/results_viewer_unittest.html View 1 chunk +18 lines, -0 lines 0 comments Download
D tools/telemetry/telemetry/web_components/results_viewer_unittest.js View 1 chunk +0 lines, -16 lines 0 comments Download
A + tools/telemetry/telemetry/web_components/viewer_unittest_data.html View 2 chunks +9 lines, -6 lines 0 comments Download
D tools/telemetry/telemetry/web_components/viewer_unittest_data.js View 1 chunk +0 lines, -34 lines 0 comments Download
M tools/telemetry/telemetry/web_components/web_components_project.py View 1 2 1 chunk +25 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
nduca
fyi
6 years, 5 months ago (2014-07-24 16:49:06 UTC) #1
dtu
lgtm
6 years, 5 months ago (2014-07-24 23:39:47 UTC) #2
nduca
The CQ bit was checked by nduca@chromium.org
6 years, 4 months ago (2014-07-28 02:58:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/418883003/100001
6 years, 4 months ago (2014-07-28 02:59:23 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-28 05:43:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-28 05:53:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clang_dbg/builds/371)
6 years, 4 months ago (2014-07-28 05:53:41 UTC) #7
nduca
tryserver.chromium.linus is fail
6 years, 4 months ago (2014-07-28 06:42:06 UTC) #8
nduca
The CQ bit was checked by nduca@chromium.org
6 years, 4 months ago (2014-07-28 06:42:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/418883003/100001
6 years, 4 months ago (2014-07-28 06:42:55 UTC) #10
nduca
The CQ bit was checked by nduca@chromium.org
6 years, 4 months ago (2014-07-28 06:43:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/418883003/100001
6 years, 4 months ago (2014-07-28 06:43:56 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 06:59:59 UTC) #13
Message was sent while issue was closed.
Change committed as 285874

Powered by Google App Engine
This is Rietveld 408576698