Simplify wrap_contents mode.

Simplify android_webview wrap_contents mode.

This changes the webview implementation of wrap_contents mode
from custom code explicitly calculating the layout size to a
pair of settings: "ignore viewport tag" (for older apps) and
"set layout size height to 0".

This means this code gets simpler and means we don't have to
fix a bunch of races present in the current version of the
code.

BUG=392460, 398445
TBR=cevans@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288992

[mnaganov (inactive), 2014-08-08 07:45:16]

Thumbs up for the idea, but I have a couple of comments.

https://codereview.chromium.org/418883002/diff/40001/android_webview/java/src...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/418883002/diff/40001/android_webview/java/src...
android_webview/java/src/org/chromium/android_webview/AwContents.java:429: if
(android.os.Build.VERSION.SDK_INT <= android.os.Build.VERSION_CODES.KITKAT) {
In the CL description, you are saying << "ignore viewport tag" (for older apps)
>>, but this code actually checks the platform version, not the app's target sdk
version. Is this intentional?

https://codereview.chromium.org/418883002/diff/40001/android_webview/javatest...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwLayoutSizerTest.java
(right):

https://codereview.chromium.org/418883002/diff/40001/android_webview/javatest...
android_webview/javatests/src/org/chromium/android_webview/test/AwLayoutSizerTest.java:411:
assertTrue(delegate.forceZeroHeight);
I would expect to see assertFalse somewhere in the beginning and / or in the
middle.

[mkosiba (inactive), 2014-08-08 09:05:07]

https://codereview.chromium.org/418883002/diff/40001/android_webview/java/src...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/418883002/diff/40001/android_webview/java/src...
android_webview/java/src/org/chromium/android_webview/AwContents.java:429: if
(android.os.Build.VERSION.SDK_INT <= android.os.Build.VERSION_CODES.KITKAT) {
On 2014/08/08 07:45:16, Mikhail Naganov (Cr) wrote:
> In the CL description, you are saying << "ignore viewport tag" (for older
apps)
> >>, but this code actually checks the platform version, not the app's target
sdk
> version. Is this intentional?

argh, I forgot to upload my latest changes. You're right, this is incorrect. We
should be checking the targetSDK instead, but that's less testable so I ended up
adding a 'if zeroLayout then ignore viewport quirk' setting. The glue layer can
then set that according to targetSdk.

https://codereview.chromium.org/418883002/diff/40001/android_webview/javatest...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwLayoutSizerTest.java
(right):

https://codereview.chromium.org/418883002/diff/40001/android_webview/javatest...
android_webview/javatests/src/org/chromium/android_webview/test/AwLayoutSizerTest.java:411:
assertTrue(delegate.forceZeroHeight);
On 2014/08/08 07:45:16, Mikhail Naganov (Cr) wrote:
> I would expect to see assertFalse somewhere in the beginning and / or in the
> middle.

Done.

[mnaganov (inactive), 2014-08-08 10:12:36]

lgtm

[mkosiba (inactive), 2014-08-11 11:02:14]

cevans@chromium.org: Please review changes in webview and content IPC

jochen@chromium.org: Please review changes in content/

[jochen (gone - plz use gerrit), 2014-08-11 14:25:50]

lgtm

[mkosiba (inactive), 2014-08-12 09:07:12]

I'm going to TBR cevans@chromium.org since the IPC changes are trivial (delete
one message and add a boolean to the preferences update message).

[mkosiba (inactive), 2014-08-12 09:07:34]

The CQ bit was checked by mkosiba@chromium.org

[commit-bot: I haz the power, 2014-08-12 09:09:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mkosiba@chromium.org/418883002/100001

[commit-bot: I haz the power, 2014-08-12 15:48:52]

Change committed as 288992