Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 418853002: Android:Allow to invoke a read-back while a view is visible only. (Closed)

Created:
6 years, 5 months ago by sivag
Modified:
6 years, 5 months ago
Reviewers:
no sievers, powei, piman
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow to invoke a read-back while a view is visible only. We should allow, the read back while view is active and hold the frame till, readback gets processed. Dont process a readback request when the view is hidden. BUG=376769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285488

Patch Set 1 #

Patch Set 2 : Check hide view logic outside IsSurfaceAvailableForCopy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sivag
ptal..
6 years, 5 months ago (2014-07-24 09:56:47 UTC) #1
no sievers
+powei to confirm that this is fine, but LGTM
6 years, 5 months ago (2014-07-24 19:28:49 UTC) #2
powei
lgtm
6 years, 5 months ago (2014-07-24 23:23:24 UTC) #3
sivag
The CQ bit was checked by siva.gunturi@samsung.com
6 years, 5 months ago (2014-07-25 03:02:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siva.gunturi@samsung.com/418853002/20001
6 years, 5 months ago (2014-07-25 03:04:00 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 05:35:34 UTC) #6
Message was sent while issue was closed.
Change committed as 285488

Powered by Google App Engine
This is Rietveld 408576698