Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 418843002: Partially revert "Unflake and speedup JsNative*Sample cpu profile tests" (Closed)

Created:
6 years, 5 months ago by Michael Achenbach
Modified:
6 years, 5 months ago
Reviewers:
Benedikt Meurer, alph
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Partially revert "Unflake and speedup JsNative*Sample cpu profile tests" This reverts the test expectations of commit r22345. Several cpu profiler flakes were happening lately. BUG=v8:2999 LOG=n R=bmeurer@chromium.org TBR=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M test/cctest/cctest.status View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
FYI
6 years, 5 months ago (2014-07-24 09:24:32 UTC) #1
Benedikt Meurer
lgtm
6 years, 5 months ago (2014-07-24 09:24:53 UTC) #2
Michael Achenbach
6 years, 5 months ago (2014-07-24 09:26:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22588 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698