Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 418823002: Add ScriptValue.v8ValueUnsafe() to access the V8 value without cross-context access check. (Closed)

Created:
6 years, 5 months ago by aandrey
Modified:
6 years, 4 months ago
Reviewers:
haraken, yurys
CC:
blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, arv+blink, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, loislo+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Add ScriptValue.v8ValueUnsafe() to access the V8 value without cross-context access check. In DevTools instrumentation we may need to access an async stack trace object wrapped into a ScriptValue from a different world. We would unwrap it to a native object only to get it's String and number members, and not passing the object to user's scripts. BUG=396916 R=yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178944

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M Source/bindings/core/v8/ScriptDebugServer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptDebugServer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ScriptValue.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/core/v8/ScriptValue.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
aandrey
6 years, 5 months ago (2014-07-24 08:23:28 UTC) #1
yurys
This way you will expose access to objects from different context through JavaScriptCallFrame. No one ...
6 years, 5 months ago (2014-07-24 11:15:21 UTC) #2
yurys
If it is just for serializing the frame we should be able to do it ...
6 years, 5 months ago (2014-07-24 11:16:09 UTC) #3
aandrey
On 2014/07/24 11:15:21, yurys wrote: > Why do you need to pass JavaScriptCallFrame to another ...
6 years, 5 months ago (2014-07-24 11:23:26 UTC) #4
yurys
On 2014/07/24 11:23:26, aandrey wrote: > On 2014/07/24 11:15:21, yurys wrote: > > Why do ...
6 years, 5 months ago (2014-07-24 11:54:30 UTC) #5
aandrey
@haraken, are you OK with this change?
6 years, 5 months ago (2014-07-24 11:56:41 UTC) #6
aandrey
ping?
6 years, 4 months ago (2014-07-25 15:56:47 UTC) #7
haraken
Sorry, I missed this. LGTM.
6 years, 4 months ago (2014-07-25 16:00:34 UTC) #8
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-07-25 16:02:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/418823002/1
6 years, 4 months ago (2014-07-25 16:02:33 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-07-25 17:11:17 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-07-25 17:39:40 UTC) #12
Message was sent while issue was closed.
Change committed as 178944

Powered by Google App Engine
This is Rietveld 408576698