chrome/browser/download/download_file_manager.cc - Issue 4188008: Use make_scoped_refptr for NewRunnableMethod if the raw ptr type is derivd from RefCountedThreadSafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_file_manager.cc

Issue 4188008: Use make_scoped_refptr for NewRunnableMethod if the raw ptr type is derivd from RefCountedThreadSafe (Closed) Base URL: http://git.chromium.org/git/chromium.git

Patch Set: address comment Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/download/download_file_manager.cc

diff --git a/chrome/browser/download/download_file_manager.cc b/chrome/browser/download/download_file_manager.cc

index 8415c8791a7083d0fdf17e078e8c6b4de462e112..a8202e1330a6a6af69a61d8339878454e9f80aae 100644

--- a/chrome/browser/download/download_file_manager.cc

+++ b/chrome/browser/download/download_file_manager.cc

@@ -176,7 +176,7 @@ void DownloadFileManager::StartDownload(DownloadCreateInfo* info) {

BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,

NewRunnableMethod(this, &DownloadFileManager::CreateDownloadFile,

- info, manager));

+ info, make_scoped_refptr(manager)));

}

// We don't forward an update to the UI thread here, since we want to throttle

« no previous file with comments | « chrome/browser/debugger/devtools_http_protocol_handler.cc ('k') | chrome/browser/file_path_watcher_browsertest.cc » ('j') | no next file with comments »