Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 418763002: Add GN Build file for extensions_browser target. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
Yoyo Zhou, brettw
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Yoyo Zhou, James Cook, not at google - send to devlin
Project:
chromium
Visibility:
Public.

Description

Add GN Build file for extensions_browser target. BUG=None TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn extensions/browser R=brettw@chromium.org TBR=yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285800

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : review #

Patch Set 4 : includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -0 lines) Patch
M BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
A extensions/browser/BUILD.gn View 1 2 3 1 chunk +254 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
6 years, 5 months ago (2014-07-24 00:36:55 UTC) #1
tfarina
Brett, Yoyo, ping??
6 years, 5 months ago (2014-07-24 22:23:05 UTC) #2
Yoyo Zhou
I'm sorry, but I'm not familiar enough with GN to review. Brett should look at ...
6 years, 5 months ago (2014-07-24 22:25:59 UTC) #3
brettw
LGTM with change https://codereview.chromium.org/418763002/diff/20001/extensions/browser/BUILD.gn File extensions/browser/BUILD.gn (right): https://codereview.chromium.org/418763002/diff/20001/extensions/browser/BUILD.gn#newcode242 extensions/browser/BUILD.gn:242: sources -= [ Personally I think ...
6 years, 5 months ago (2014-07-24 22:26:12 UTC) #4
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-26 02:05:07 UTC) #5
tfarina
https://codereview.chromium.org/418763002/diff/20001/extensions/browser/BUILD.gn File extensions/browser/BUILD.gn (right): https://codereview.chromium.org/418763002/diff/20001/extensions/browser/BUILD.gn#newcode242 extensions/browser/BUILD.gn:242: sources -= [ On 2014/07/24 22:26:12, brettw wrote: > ...
6 years, 5 months ago (2014-07-26 02:05:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/418763002/60001
6 years, 5 months ago (2014-07-26 05:00:40 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-26 20:06:39 UTC) #8
Message was sent while issue was closed.
Change committed as 285800

Powered by Google App Engine
This is Rietveld 408576698