Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: tools/telemetry/telemetry/core/browser_unittest.py

Issue 418733002: Prevent duplicate navigation to debug URLs from Telemetry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix comment. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/system_info_backend.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/browser_unittest.py
diff --git a/tools/telemetry/telemetry/core/browser_unittest.py b/tools/telemetry/telemetry/core/browser_unittest.py
index eeb3d8d1b9d9a02692dae2503db5f504d7e16d56..9a44089c55e36dbb7e2ad1201bc2297d3f0d898f 100644
--- a/tools/telemetry/telemetry/core/browser_unittest.py
+++ b/tools/telemetry/telemetry/core/browser_unittest.py
@@ -157,6 +157,17 @@ class BrowserTest(unittest.TestCase):
for g in info.gpu.devices:
self.assertTrue(isinstance(g, gpu_device.GPUDevice))
+ def testGetSystemInfoNotCachedObject(self):
+ b = self.CreateBrowser()
+ if not b.supports_system_info:
+ logging.warning(
+ 'Browser does not support getting system info, skipping test.')
+ return
+
+ info_a = b.GetSystemInfo()
+ info_b = b.GetSystemInfo()
+ self.assertFalse(info_a is info_b)
+
def testGetSystemTotalMemory(self):
b = self.CreateBrowser()
self.assertTrue(b.memory_stats['SystemTotalPhysicalMemory'] > 0)
« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/system_info_backend.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698