ui/webui/resources/js/cr.js - Issue 418663002: Typecheck JS files for chrome://help before doing import transition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr.js

Issue 418663002: Typecheck JS files for chrome://help before doing import transition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@json_to_pydict

Patch Set: Yet last fixes Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/webui/resources/js/cr.js

diff --git a/ui/webui/resources/js/cr.js b/ui/webui/resources/js/cr.js

index cdaed720b2b921447045bf28e220a3f1e80deecf..888cc54d52a177d0bce967250ff848d8479b5ff0 100644

--- a/ui/webui/resources/js/cr.js

+++ b/ui/webui/resources/js/cr.js

@@ -129,8 +129,8 @@ var cr = (function() {

* for.

* @param {PropertyKind} kind The kind of property we are getting the

* setter for.

- * @param {function():void=} opt_setHook A function to run after the property

- * is set, but before the propertyChange event is fired.

+ * @param {function(*, *):void=} opt_setHook A function to run after the

Dan Beam 2014/08/06 16:06:59 this is fixed here: https://chromiumcodereview.app

Vitaly Pavlenko 2014/08/07 18:18:13 This file is removed in my Patch Set #6.

+ * property is set, but before the propertyChange event is fired.

* @return {function(*):void} The function to use as a setter.

function getSetter(name, kind, opt_setHook) {

« ui/webui/resources/js/assert.js ('K') | « ui/webui/resources/js/assert.js ('k') | ui/webui/resources/js/cr/ui/focus_manager.js » ('j') | no next file with comments »