third_party/closure_compiler/checker.py - Issue 418663002: Typecheck JS files for chrome://help before doing import transition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/closure_compiler/checker.py

Issue 418663002: Typecheck JS files for chrome://help before doing import transition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@json_to_pydict

Patch Set: Yet last fixes Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/closure_compiler/checker.py

diff --git a/third_party/closure_compiler/checker.py b/third_party/closure_compiler/checker.py

index be7b6f719aebf033ee2a1558a20d0823708d2fbe..5ae34951f399d68082667aed5c3d1f10d69ebbab 100644

--- a/third_party/closure_compiler/checker.py

+++ b/third_party/closure_compiler/checker.py

@@ -71,7 +71,9 @@ class Checker(object):

"--jscomp_error=accessControls",

"--jscomp_error=ambiguousFunctionDecl",

"--jscomp_error=checkStructDictInheritance",

- "--jscomp_error=checkTypes",

+ # TODO(vitalyp): switch to jscomp_error after transition to new imports

Dan Beam 2014/08/06 16:06:59 do we still need this?

Vitaly Pavlenko 2014/08/07 18:18:13 I removed it in Patch Set #6.

+ "--jscomp_warning=checkTypes",

+ # "--jscomp_error=newCheckTypes",

"--jscomp_error=checkVars",

"--jscomp_error=constantProperty",

"--jscomp_error=deprecated",

@@ -79,7 +81,8 @@ class Checker(object):

"--jscomp_error=globalThis",

"--jscomp_error=invalidCasts",

"--jscomp_error=misplacedTypeAnnotation",

- "--jscomp_error=missingProperties",

+ # TODO(vitalyp): switch to jscomp_error after transition to new imports

+ "--jscomp_warning=missingProperties",

"--jscomp_error=missingReturn",

"--jscomp_error=nonStandardJsDocs",

"--jscomp_error=suspiciousCode",

« compiled.resources ('K') | « compiled.resources ('k') | third_party/closure_compiler/externs/pending_compiler_externs.js » ('j') | ui/webui/resources/js/assert.js » ('J')