Typecheck JS files for chrome://help before doing import transition

third_party/closure_compiler/checker.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 import os
 import re
 import subprocess
 import sys
 import tempfile
@@ skipping 53 matching lines @@
 
 class Checker(object):
   _common_closure_args = [
     "--accept_const_keyword",
     "--language_in=ECMASCRIPT5",
     "--summary_detail_level=3",
     "--warning_level=VERBOSE",
     "--jscomp_error=accessControls",
     "--jscomp_error=ambiguousFunctionDecl",
     "--jscomp_error=checkStructDictInheritance",
-    "--jscomp_error=checkTypes",
+    # TODO(vitalyp): switch to jscomp_error after transition to new imports
+    "--jscomp_warning=checkTypes",

[Dan Beam, 2014/07/23 22:09:24]

did @suppress {checkTypes} not work?  i don't think we want to do this, as no
type errors will "break the build" so to speak (they wouldn't return a non-zero
exit code)

[Vitaly Pavlenko, 2014/07/24 00:59:58]

I'll enable it in the next CL where I switch to cr.exportPath() and references
to module functions no longer cause compiler error.

+    # "--jscomp_error=newCheckTypes",
     "--jscomp_error=checkVars",
     "--jscomp_error=constantProperty",
     "--jscomp_error=deprecated",
     "--jscomp_error=externsValidation",
     "--jscomp_error=globalThis",
     "--jscomp_error=invalidCasts",
     "--jscomp_error=misplacedTypeAnnotation",
-    "--jscomp_error=missingProperties",
+    # TODO(vitalyp): switch to jscomp_error after transition to new imports

[Dan Beam, 2014/07/23 22:09:24]

maybe we could stand for this, but why can't we just suppress or hack around?

[Vitaly Pavlenko, 2014/07/24 01:09:31]

I caught a situation when the suppress declaration didn't work.

+    "--jscomp_warning=missingProperties",
     "--jscomp_error=missingReturn",
     "--jscomp_error=nonStandardJsDocs",
     "--jscomp_error=suspiciousCode",
     "--jscomp_error=undefinedNames",
     "--jscomp_error=undefinedVars",
     "--jscomp_error=unknownDefines",
     "--jscomp_error=uselessCode",
     "--jscomp_error=visibility",
     # TODO(dbeam): happens when the same file is <include>d multiple times.
     "--jscomp_off=duplicate",
@@ skipping 117 matching lines @@
 
     output = self._format_errors(map(self._fix_up_error, errors))
     if runner_cmd.returncode:
       self._fatal("Error in: " + file + ("\n" + output if output else ""))
     elif output:
       self._debug("Output: " + output)
 
     self._clean_up()
 
     return runner_cmd.returncode == 0