Source/platform/graphics/ImageFrameGenerator.cpp - Issue 418653002: Allowing YUV data to be retrieved from the JPEG Decoder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/ImageFrameGenerator.cpp

Issue 418653002: Allowing YUV data to be retrieved from the JPEG Decoder. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed changes to ImageFrameGenerator for now Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/platform/graphics/DeferredImageDecoderTest.cpp ('k') | Source/platform/graphics/test/MockImageDecoder.h » ('j') | Source/platform/image-decoders/ImageDecoder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/ImageFrameGenerator.cpp

diff --git a/Source/platform/graphics/ImageFrameGenerator.cpp b/Source/platform/graphics/ImageFrameGenerator.cpp

index 73c08f1236c6e4b7a7605aade37e30aae9b9e7e4..b650a08649fd4cd0db51de9a983d339885bce796 100644

--- a/Source/platform/graphics/ImageFrameGenerator.cpp

+++ b/Source/platform/graphics/ImageFrameGenerator.cpp

@@ -133,7 +133,7 @@ bool ImageFrameGenerator::decodeAndScale(const SkImageInfo& info, size_t index,

ASSERT(m_fullSize == scaledSize);

if (m_decodeFailedAndEmpty)

- return 0;

+ return false;

Noel Gordon 2014/07/25 15:55:01 This change seems unrelated to yuv decoding. Perh

sugoi1 2014/07/25 16:56:47 Done.

TRACE_EVENT2("blink", "ImageFrameGenerator::decodeAndScale", "generator", this, "decodeCount", static_cast<int>(m_decodeCount));