Allowing YUV data to be retrieved from the JPEG Decoder.

Source/platform/image-decoders/jpeg/JPEGImageDecoder.h

 /*
  * Copyright (C) 2006 Apple Computer, Inc.  All rights reserved.
  * Copyright (C) 2008-2009 Torch Mobile, Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 29 matching lines @@
 class PLATFORM_EXPORT JPEGImageDecoder : public ImageDecoder {
     WTF_MAKE_NONCOPYABLE(JPEGImageDecoder);
 public:
     JPEGImageDecoder(ImageSource::AlphaOption, ImageSource::GammaAndColorProfileOption, size_t maxDecodedBytes);
     virtual ~JPEGImageDecoder();
 
     // ImageDecoder
     virtual String filenameExtension() const OVERRIDE { return "jpg"; }
     virtual bool isSizeAvailable() OVERRIDE;
     virtual bool hasColorProfile() const OVERRIDE { return m_hasColorProfile; }
-    virtual IntSize decodedSize() const OVERRIDE { return m_decodedSize; }
+    virtual IntSize decodedSize(int component = 0) const OVERRIDE;
     virtual bool setSize(unsigned width, unsigned height) OVERRIDE;
     virtual ImageFrame* frameBufferAtIndex(size_t) OVERRIDE;
     // CAUTION: setFailed() deletes |m_reader|.  Be careful to avoid
     // accessing deleted memory, especially when calling this from inside
     // JPEGImageReader!
     virtual bool setFailed() OVERRIDE;
+    virtual void setAcceleratedYUVDecoding(bool acceleratedYUVDecoding) OVERRIDE { m_acceleratedYUVDecoding = acceleratedYUVDecoding; }

[Alpha Left Google, 2014/07/24 22:07:27]

This should be enableAcceleratedYUVDecoding() and be merged with
setDecodingBuffers().

+    virtual bool acceleratedYUVDecoding() const OVERRIDE { return m_acceleratedYUVDecoding; }
+    virtual bool doAcceleratedYUVDecoding() OVERRIDE;
+    virtual void setDecodingBuffers(OwnPtr<DecodingBuffers>&) OVERRIDE;
 
     bool outputScanlines();
     unsigned desiredScaleNumerator() const;
     void jpegComplete();
 
     void setOrientation(ImageOrientation orientation) { m_orientation = orientation; }
     void setHasColorProfile(bool hasColorProfile) { m_hasColorProfile = hasColorProfile; }
     void setDecodedSize(unsigned width, unsigned height);
 
 private:
     // Decodes the image.  If |onlySize| is true, stops decoding after
     // calculating the image size.  If decoding fails but there is no more
     // data coming, sets the "decode failure" flag.
     void decode(bool onlySize);
 
     OwnPtr<JPEGImageReader> m_reader;
+    OwnPtr<DecodingBuffers> m_decodingBuffers;
     IntSize m_decodedSize;
     bool m_hasColorProfile;
+    bool m_acceleratedYUVDecoding;

[Alpha Left Google, 2014/07/24 22:07:27]

If there's DecodingBuffers there's no need to have this flag.

[sugoi1, 2014/07/24 23:16:38]

The current workflow does require a separate flag, let me explain why:

Step 1: Query the YUV size (by setting this flag)
Step 2: The caller allocates the memory
Step 3: The caller sends the allocated memory through setDecodingBuffers

I agree with you that, in step 3, the flag wouldn't be necessary, but the flag
is necessary for step 1, at a point where the buffers are not allocated yet.
Would you prefer that I send an empty DecodingBuffer object in step 1 instead of
the flag?

 };
 
 } // namespace blink
 
 #endif