Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 418643004: Copy git tooling into testing_support. (Closed)

Created:
6 years, 5 months ago by iannucci
Modified:
6 years, 5 months ago
Reviewers:
Vadim Sh., agable
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/testing/testing_support@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix scripts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+579 lines, --1 lines) Patch
A .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
A README.md View 1 chunk +10 lines, -0 lines 0 comments Download
A setup.py View 1 1 chunk +39 lines, -0 lines 0 comments Download
A testing_support/__init__.py View 1 chunk +10 lines, -0 lines 0 comments Download
A testing_support/git/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A testing_support/git/repo.py View 1 chunk +239 lines, -0 lines 0 comments Download
A testing_support/git/schema.py View 1 chunk +124 lines, -0 lines 0 comments Download
A testing_support/git/unittest_helpers.py View 1 chunk +81 lines, -0 lines 0 comments Download
A testing_support/git/util.py View 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
iannucci
6 years, 5 months ago (2014-07-23 21:51:04 UTC) #1
Vadim Sh.
https://codereview.chromium.org/418643004/diff/1/setup.py File setup.py (right): https://codereview.chromium.org/418643004/diff/1/setup.py#newcode39 setup.py:39: scripts=['scripts/expect_tests'], is this correct?
6 years, 5 months ago (2014-07-23 22:14:50 UTC) #2
iannucci
oops, good catch :)
6 years, 5 months ago (2014-07-23 22:21:12 UTC) #3
Vadim Sh.
lgtm
6 years, 5 months ago (2014-07-23 22:32:46 UTC) #4
iannucci
6 years, 5 months ago (2014-07-23 22:39:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as rfc2ed27 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698