Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1432)

Issue 418603003: [usb_gadget p05] Add a HID mouse gadget. (Closed)

Created:
6 years, 5 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[usb_gadget p05] Add a HID mouse gadget. An example HID gadget implementing the standard HID mouse protocol. BUG=396682 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285383

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Fix a copy-paste error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -37 lines) Patch
M tools/usb_gadget/hid_descriptors_test.py View 3 chunks +2 lines, -37 lines 0 comments Download
A tools/usb_gadget/mouse_gadget.py View 1 1 chunk +119 lines, -0 lines 0 comments Download
A tools/usb_gadget/mouse_gadget_test.py View 1 chunk +50 lines, -0 lines 0 comments Download
M tools/usb_gadget/usb_constants.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Reilly Grant (use Gerrit)
6 years, 5 months ago (2014-07-23 20:27:53 UTC) #1
rpaquay
https://codereview.chromium.org/418603003/diff/20001/tools/usb_gadget/mouse_gadget.py File tools/usb_gadget/mouse_gadget.py (right): https://codereview.chromium.org/418603003/diff/20001/tools/usb_gadget/mouse_gadget.py#newcode7 tools/usb_gadget/mouse_gadget.py:7: Two classes are provided by this module. The KeyboardFeature ...
6 years, 5 months ago (2014-07-23 22:44:12 UTC) #2
Reilly Grant (use Gerrit)
https://codereview.chromium.org/418603003/diff/20001/tools/usb_gadget/mouse_gadget.py File tools/usb_gadget/mouse_gadget.py (right): https://codereview.chromium.org/418603003/diff/20001/tools/usb_gadget/mouse_gadget.py#newcode7 tools/usb_gadget/mouse_gadget.py:7: Two classes are provided by this module. The KeyboardFeature ...
6 years, 5 months ago (2014-07-23 22:48:30 UTC) #3
Ken Rockot(use gerrit already)
lgtm
6 years, 5 months ago (2014-07-24 03:09:17 UTC) #4
Reilly Grant (use Gerrit)
The CQ bit was checked by reillyg@chromium.org
6 years, 5 months ago (2014-07-24 16:57:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/418603003/40001
6 years, 5 months ago (2014-07-24 17:00:19 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 20:15:56 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 21:43:21 UTC) #8
Message was sent while issue was closed.
Change committed as 285383

Powered by Google App Engine
This is Rietveld 408576698