Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: tools/gn/ninja_binary_target_writer_unittest.cc

Issue 418573002: Don't add implicit deps to copy commands in GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/function_toolchain.cc ('k') | tools/gn/ninja_copy_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_binary_target_writer_unittest.cc
diff --git a/tools/gn/ninja_binary_target_writer_unittest.cc b/tools/gn/ninja_binary_target_writer_unittest.cc
index bcaeae720fe22011df63257d73e9afd68f1f9cde..be2a5b53b7de36637f018b6e4e5099b40963d16e 100644
--- a/tools/gn/ninja_binary_target_writer_unittest.cc
+++ b/tools/gn/ninja_binary_target_writer_unittest.cc
@@ -39,6 +39,9 @@ TEST(NinjaBinaryTargetWriter, SourceSet) {
"cflags_cc =\n"
"cflags_objc =\n"
"cflags_objcc =\n"
+ "target_name = bar\n"
+ "target_out_dir = obj/foo\n"
+ "root_out_dir = \n"
"\n"
"build obj/foo/bar.input1.obj: cxx ../../foo/input1.cc\n"
"build obj/foo/bar.input2.obj: cxx ../../foo/input2.cc\n"
@@ -73,6 +76,9 @@ TEST(NinjaBinaryTargetWriter, SourceSet) {
"cflags_cc =\n"
"cflags_objc =\n"
"cflags_objcc =\n"
+ "target_name = shlib\n"
+ "target_out_dir = obj/foo\n"
+ "root_out_dir = \n"
"\n"
"\n"
"manifests = obj/foo/shlib.intermediate.manifest\n"
@@ -116,6 +122,9 @@ TEST(NinjaBinaryTargetWriter, SourceSet) {
"cflags_cc =\n"
"cflags_objc =\n"
"cflags_objcc =\n"
+ "target_name = stlib\n"
+ "target_out_dir = obj/foo\n"
+ "root_out_dir = \n"
"\n"
"\n"
"manifests = obj/foo/stlib.intermediate.manifest\n"
@@ -159,6 +168,9 @@ TEST(NinjaBinaryTargetWriter, ProductExtension) {
"cflags_cc =\n"
"cflags_objc =\n"
"cflags_objcc =\n"
+ "target_name = shlib\n"
+ "target_out_dir = obj/foo\n"
+ "root_out_dir = \n"
"\n"
"build obj/foo/shlib.input1.o: cxx ../../foo/input1.cc\n"
"build obj/foo/shlib.input2.o: cxx ../../foo/input2.cc\n"
@@ -205,6 +217,9 @@ TEST(NinjaBinaryTargetWriter, EmptyProductExtension) {
"cflags_cc =\n"
"cflags_objc =\n"
"cflags_objcc =\n"
+ "target_name = shlib\n"
+ "target_out_dir = obj/foo\n"
+ "root_out_dir = \n"
"\n"
"build obj/foo/shlib.input1.o: cxx ../../foo/input1.cc\n"
"build obj/foo/shlib.input2.o: cxx ../../foo/input2.cc\n"
« no previous file with comments | « tools/gn/function_toolchain.cc ('k') | tools/gn/ninja_copy_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698