Issue 418573002: Don't add implicit deps to copy commands in GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 418573002: Don't add implicit deps to copy commands in GN. (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
scottmg

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Don't add implicit deps to copy commands in GN. As explained in the long comment in ninja_copy_target_writer.cc, writing implicit deps for the copy command is both unnecessary and causes problems given the way Chrome specifies the command. This also updates the expectations for the binary output given the new variables added in a previous patch (this test isn't being run on the bot yet). R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285052

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -18 lines)			Patch
M	tools/gn/function_toolchain.cc	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	tools/gn/ninja_binary_target_writer_unittest.cc	View	5 chunks	+15 lines, -0 lines	0 comments	Download
M	tools/gn/ninja_copy_target_writer.cc	View	2 chunks	+22 lines, -4 lines	0 comments	Download
M	tools/gn/ninja_copy_target_writer_unittest.cc	View	3 chunks	+2 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

6 years, 5 months ago (2014-07-23 22:05:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r285052 (presubmit successful).

Expand Messages | Collapse Messages