Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 418563002: Remove unnecessary aligned memory check when __SSE__ is used (Closed)

Created:
6 years, 5 months ago by Bo Xu
Modified:
6 years, 5 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Remove unnecessary aligned memory check when __SSE__ is used Since the land of https://pdfium.googlesource.com/pdfium/+/3522876d5291922ddc62bf1b70d02743b0850673, memory is assured to be 16 byte aligned. So no need to do this check. Plus, the removed code was causing bug in M36: https://code.google.com/p/pdfium/issues/detail?id=27. BUG=None R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/f7f6b0c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -52 lines) Patch
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/mct.c View 1 chunk +37 lines, -52 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bo Xu
6 years, 5 months ago (2014-07-23 19:26:49 UTC) #1
Lei Zhang
lgtm
6 years, 5 months ago (2014-07-23 19:38:41 UTC) #2
Bo Xu
6 years, 5 months ago (2014-07-23 20:05:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as rf7f6b0c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698