Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 418553004: Temporarily ignore maps_pixel_test failures while investigating root cause of bug. (Closed)

Created:
6 years, 5 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Project:
tools
Visibility:
Public.

Description

Temporarily ignore maps_pixel_test failures while investigating root cause of bug. BUG=395914 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=285048

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review feedback from stip. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M scripts/slave/gatekeeper.json View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ken Russell (switch to Gerrit)
PTAL
6 years, 5 months ago (2014-07-23 21:29:50 UTC) #1
ghost stip (do not use)
lgtm w/ optional comment https://codereview.chromium.org/418553004/diff/1/scripts/slave/gatekeeper.json File scripts/slave/gatekeeper.json (right): https://codereview.chromium.org/418553004/diff/1/scripts/slave/gatekeeper.json#newcode117 scripts/slave/gatekeeper.json:117: "excluded_steps": [ "comment": ["Re-enable maps_pixel_test ...
6 years, 5 months ago (2014-07-23 21:32:29 UTC) #2
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/418553004/diff/1/scripts/slave/gatekeeper.json File scripts/slave/gatekeeper.json (right): https://codereview.chromium.org/418553004/diff/1/scripts/slave/gatekeeper.json#newcode117 scripts/slave/gatekeeper.json:117: "excluded_steps": [ On 2014/07/23 21:32:29, stip wrote: > "comment": ...
6 years, 5 months ago (2014-07-23 21:40:00 UTC) #3
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 5 months ago (2014-07-23 21:40:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/418553004/20001
6 years, 5 months ago (2014-07-23 21:40:14 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 21:40:43 UTC) #6
Message was sent while issue was closed. 
Change committed as 285048

Powered by Google App Engine
This is Rietveld 408576698