Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 418553003: Implement TLS_FALLBACK_SCSV for SSLClientSocketOpenSSL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/ssl_client_socket_openssl.cc ('k') | third_party/tlslite/patches/fallback_scsv.patch » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index c44b1a60a6627a295aa51072567fb5209eacf3b2..791904eed9b53753dc5e0fe7df8f369a12e10f5b 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -7048,11 +7048,7 @@ TEST_F(HTTPSFallbackTest, TLSv1FallbackReset) {
// Tests that we don't fallback on handshake failure with servers that implement
// TLS_FALLBACK_SCSV. Also ensure that the original error code is reported.
-#if defined(USE_OPENSSL)
-TEST_F(HTTPSFallbackTest, DISABLED_FallbackSCSV) {
-#else
TEST_F(HTTPSFallbackTest, FallbackSCSV) {
-#endif
SpawnedTestServer::SSLOptions ssl_options(
SpawnedTestServer::SSLOptions::CERT_OK);
// Configure HTTPS server to be intolerant of TLS >= 1.0 in order to trigger
@@ -7074,11 +7070,7 @@ TEST_F(HTTPSFallbackTest, FallbackSCSV) {
// Tests that we don't fallback on connection closed with servers that implement
// TLS_FALLBACK_SCSV. Also ensure that the original error code is reported.
-#if defined(USE_OPENSSL)
-TEST_F(HTTPSFallbackTest, DISABLED_FallbackSCSVClosed) {
-#else
TEST_F(HTTPSFallbackTest, FallbackSCSVClosed) {
-#endif
SpawnedTestServer::SSLOptions ssl_options(
SpawnedTestServer::SSLOptions::CERT_OK);
// Configure HTTPS server to be intolerant of TLS >= 1.0 in order to trigger
« no previous file with comments | « net/socket/ssl_client_socket_openssl.cc ('k') | third_party/tlslite/patches/fallback_scsv.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698