Show the window controls for 3s on entering full-screen mode.

Show the window controls for 3s on entering full-screen mode.

This addresses some discoverability concerns. LMK if you think it's sufficient.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285617

[Jamie, 2014-07-23 18:41:12]

ptal

[kelvinp, 2014-07-23 22:48:15]

LGTM

Regarding the user experience, I think this is a good idea.  The problem with
auto-hide controls is that they are not very discover-able (e.g the Windows 8
edgy controls) and I think this change will make the experience better.

One piece of non-related feedback is that it takes me a while to realize that
clicking on the stub will pin the controls.  Maybe we should add a tool tip?

I will play around with the v2 app more once the remove tool bar change is
checked-in and provide more feedbacks.

Regarding the code change looks good, it looks good in general.  I don't
remember whether we have reached consensus about a clean up pattern in
JavaScript (e.g. when to unhook dom events and clean up timers, etc).

[Jamie, 2014-07-24 17:01:03]

The CQ bit was checked by jamiewalch@chromium.org

[commit-bot: I haz the power, 2014-07-24 17:02:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/418543002/20001

[commit-bot: I haz the power, 2014-07-24 18:45:50]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/32785)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/37806)

[commit-bot: I haz the power, 2014-07-24 18:51:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-24 18:51:26]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/32883)

[Jamie, 2014-07-24 21:31:09]

The CQ bit was checked by jamiewalch@chromium.org

[commit-bot: I haz the power, 2014-07-24 21:31:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/418543002/60001

[commit-bot: I haz the power, 2014-07-25 01:28:16]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-25 02:29:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-25 02:29:05]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Jamie, 2014-07-25 16:15:02]

The CQ bit was checked by jamiewalch@chromium.org

[commit-bot: I haz the power, 2014-07-25 16:16:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/418543002/60001

[commit-bot: I haz the power, 2014-07-25 17:58:43]

Change committed as 285617