Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 418523002: Revert of Enable the SSSE3 compile time check on all platforms. (Closed)

Created:
6 years, 5 months ago by bungeman-skia
Modified:
6 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Enable the SSSE3 compile time check on all platforms. (https://codereview.chromium.org/403583002/) Reason for revert: This is blocking the roll. Chromium Windows trybots (like win_chromium_x64_rel) are crashing in the SSSE3 code (for example SkCanvasVideoRenderTest.CroppedFrame). Original issue's description: > Enable the SSSE3 compile time check on all platforms (3rd attempt) > > BUG=skia:2746 > > Committed: https://skia.googlesource.com/skia/+/933834851f9d48fbd85b728cc92e1f0134bfaa4e TBR=halcanary@google.com,mtklein@google.com,djsollen@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2746 Committed: https://skia.googlesource.com/skia/+/2da0f85488879d7e3072fb6449b20eca5e1b4ec5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -40 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M gyp/opts.gyp View 3 chunks +25 lines, -25 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_SSSE3.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M src/opts/SkBlurImage_opts_SSE4.cpp View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bungeman-skia
Created Revert of Enable the SSSE3 compile time check on all platforms.
6 years, 5 months ago (2014-07-23 18:27:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/418523002/1
6 years, 5 months ago (2014-07-23 18:28:14 UTC) #2
commit-bot: I haz the power
Change committed as 2da0f85488879d7e3072fb6449b20eca5e1b4ec5
6 years, 5 months ago (2014-07-23 18:28:24 UTC) #3
bungeman-skia
6 years, 5 months ago (2014-07-23 18:37:24 UTC) #4
Message was sent while issue was closed.
I was able to reproduce locally with a debug build and get more useful output
(and just to find the offending commit, the Chromium Windows bots are a bit
slow). After getting the offending Skia commit
(933834851f9d48fbd85b728cc92e1f0134bfaa4e) into my Chromium checkout, build and
run with the following:

ninja -C out\Debug media_unittests
out\Debug\media_unittests.exe --gtest_filter=SkCanvas*

An example stack trace:

[7/9] SkCanvasVideoRendererTest.SameVideoFrame (2 ms)
Note: Google Test filter = SkCanvasVideoRendererTest.CroppedFrame
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from SkCanvasVideoRendererTest
[ RUN      ] SkCanvasVideoRendererTest.CroppedFrame
[13124:12016:0723/141704:773607600:INFO:skmemory_new_handler.cpp(30)]
d:\src\chromium\src\skia\ext\skmemory_new_handler.cpp:30: failed assertion
"!"sk_throw""

[13124:12016:0723/141704:773607600:FATAL:skmemory_new_handler.cpp(30)] SK_CRASH
Backtrace:
        base::debug::StackTrace::StackTrace [0x0134CAF1+33]
(d:\src\chromium\src\base\debug\stack_trace_win.cc:209)
        logging::LogMessage::~LogMessage [0x013ECB5E+94]
(d:\src\chromium\src\base\logging.cc:548)
        SkDebugf_FileLine [0x023E1DB5+261]
(d:\src\chromium\src\skia\ext\google_logging.cc:22)
        sk_throw [0x023FCC48+72]
(d:\src\chromium\src\skia\ext\skmemory_new_handler.cpp:30)
        S32_opaque_D32_filter_DX_SSSE3 [0x02615248+8]
(d:\src\chromium\src\third_party\skia\src\opts\skbitmapprocstate_opts_ssse3.cpp:740)
        SkBitmapProcShader::BitmapProcShaderContext::shadeSpan
[0x020AA2C6+566](d:\src\chromium\src\third_party\skia\src\core\skbitmapprocshader.cpp:231)
        SkARGB32_Shader_Blitter::blitRect [0x020DDD35+693]
(d:\src\chromium\src\third_party\skia\src\core\skblitter_argb32.cpp:386)
        blitrect [0x021F7022+50]
(d:\src\chromium\src\third_party\skia\src\core\skscan.cpp:15)
        SkScan::FillIRect [0x021F6597+119]
(d:\src\chromium\src\third_party\skia\src\core\skscan.cpp:26)
        SkScan::FillRect [0x021F68A7+71]
(d:\src\chromium\src\third_party\skia\src\core\skscan.cpp:61)
        SkScan::FillRect [0x021F6993+131]
(d:\src\chromium\src\third_party\skia\src\core\skscan.cpp:103)
        SkDraw::drawRect [0x0211A3D5+629]
(d:\src\chromium\src\third_party\skia\src\core\skdraw.cpp:845)
                                                                             
a\src\core\skdraw.cpp:1281)
        SkBitmapDevice::drawBitmap [0x0209CEF2+34]
(d:\src\chromium\src\third_party\skia\src\core\skbitmapdevice.cpp:224)
        SkBitmapDevice::drawBitmapRect [0x0209D196+646]
(d:\src\chromium\src\third_party\skia\src\core\skbitmapdevice.cpp:291)
        SkCanvas::internalDrawBitmapRect [0x020EF957+359]
(d:\src\chromium\src\third_party\skia\src\core\skcanvas.cpp:1990)
        SkCanvas::drawBitmapRectToRect [0x020EBA02+50]
(d:\src\chromium\src\third_party\skia\src\core\skcanvas.cpp:2001)
        SkCanvas::drawBitmapRect [0x0202E9F6+118]
(d:\src\chromium\src\third_party\skia\include\core\skcanvas.h:858)
        media::SkCanvasVideoRenderer::Paint [0x10328626+582]
(d:\src\chromium\src\media\filters\skcanvas_video_renderer.cc:222)
        media::SkCanvasVideoRendererTest::Paint [0x009EE00B+251]
(d:\src\chromium\src\media\filters\skcanvas_video_renderer_unittest.cc:207)
        media::SkCanvasVideoRendererTest_CroppedFrame_Test::TestBody
[0x009EEACC+92]
(d:\src\chromium\src\media\filters\skcanvas_video_renderer_unittest.cc:267)

       
testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void>
[0x00BC9309+329] (d:\src\chromium\src\testing\gtest\src\gtest.cc:2045)
        testing::Test::Run [0x00BE270E+174]
(d:\src\chromium\src\testing\gtest\src\gtest.cc:2062)
        testing::TestInfo::Run [0x00BE29AD+221]
(d:\src\chromium\src\testing\gtest\src\gtest.cc:2241)
        testing::TestCase::Run [0x00BE284F+239]
(d:\src\chromium\src\testing\gtest\src\gtest.cc:2345)
        testing::internal::UnitTestImpl::RunAllTests [0x00BE2E06+726]
(d:\src\chromium\src\testing\gtest\src\gtest.cc:4066)
       
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool>
[0x00BC9801+337] (d:\src\chromium\src\testing\gtest\src\gtest.cc:2045)
        testing::UnitTest::Run [0x00BE2B03+211]
(d:\src\chromium\src\testing\gtest\src\gtest.cc:3700)
        RUN_ALL_TESTS [0x00B7E33F+15]
(d:\src\chromium\src\testing\gtest\include\gtest\gtest.h:2232)
        base::TestSuite::Run [0x00B7E589+233]
(d:\src\chromium\src\base\test\test_suite.cc:227)
        base::internal::RunnableAdapter<int (__thiscall
base::TestSuite::*)(void)>::Run [0x0073070B+27]
(d:\src\chromium\src\base\bind_internal.h:134)
        base::internal::InvokeHelper<0,int,base::internal::RunnableAdapter<int
(__thiscall base::TestSuite::*)(void)>,void __cdecl(TestSuiteNoAtExit
*)>::MakeItSo [0x0073061A+26] (d:\src\chromium\src\bas\bind_internal.h:864)
       
base::internal::Invoker<1,base::internal::BindState<base::internal::RunnableAdapter<int
(__thiscall base::TestSuite::*)(void)>,int __cdecl(base::TestSuite *),void
__cdecl(base::internal::UnretainedWrapper<TestSuiteNoAtExit>)>,int
__cdecl(base::TestSuite * [0x0073068A+74]
(d:\src\chromium\src\base\bind_internal.h:1169)
        base::Callback<int __cdecl(void)>::Run [0x00B7822F+47]
(d:\src\chromium\src\base\callback.h:401)
        base::`anonymous namespace'::LaunchUnitTestsInternal [0x00B771CF+895]
(d:\src\chromium\src\base\test\launcher\unit_test_launcher.cc:498)
        base::LaunchUnitTests [0x00B76D35+165]
(d:\src\chromium\src\base\test\launcher\unit_test_launcher.cc:557)
        main [0x007307FC+140]
(d:\src\chromium\src\media\base\run_all_unittests.cc:47)
        __tmainCRTStartup [0x00D2A559+409]
(f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:626)
        mainCRTStartup [0x00D2A69D+13]
(f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:466)
        BaseThreadInitThunk [0x76A4338A+18]
        RtlInitializeExceptionChain [0x77699F72+99]
        RtlInitializeExceptionChain [0x77699F45+54]

Powered by Google App Engine
This is Rietveld 408576698