Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: Source/core/rendering/RenderLayerScrollableArea.cpp

Issue 418483004: Fix scrollbar damage accumulation issue (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 199
200 if (scrollRect.isEmpty()) 200 if (scrollRect.isEmpty())
201 return; 201 return;
202 202
203 LayoutRect repaintRect = scrollRect; 203 LayoutRect repaintRect = scrollRect;
204 box().flipForWritingMode(repaintRect); 204 box().flipForWritingMode(repaintRect);
205 205
206 IntRect intRect = pixelSnappedIntRect(repaintRect); 206 IntRect intRect = pixelSnappedIntRect(repaintRect);
207 207
208 if (box().frameView()->isInPerformLayout()) { 208 if (box().frameView()->isInPerformLayout()) {
209 if (scrollbar == m_vBar.get()) { 209 addScrollbarDamage(scrollbar, intRect);
210 m_verticalBarDamage = intRect; 210 box().setMayNeedPaintInvalidation(true);
Julien - ping for review 2014/07/23 20:46:23 I don't really like this change. If we need to gen
Julien - ping for review 2014/07/23 20:46:23 I don't really like this change. If we need to gen
Xianzhu 2014/07/24 00:33:48 Removed the above statement.
211 m_hasVerticalBarDamage = true;
212 } else {
213 m_horizontalBarDamage = intRect;
214 m_hasHorizontalBarDamage = true;
215 }
216
217 } else { 211 } else {
218 box().invalidatePaintRectangle(intRect); 212 box().invalidatePaintRectangle(intRect);
219 } 213 }
220 } 214 }
221 215
222 void RenderLayerScrollableArea::invalidateScrollCornerRect(const IntRect& rect) 216 void RenderLayerScrollableArea::invalidateScrollCornerRect(const IntRect& rect)
223 { 217 {
224 if (GraphicsLayer* layer = layerForScrollCorner()) { 218 if (GraphicsLayer* layer = layerForScrollCorner()) {
225 layer->setNeedsDisplayInRect(rect); 219 layer->setNeedsDisplayInRect(rect);
226 return; 220 return;
(...skipping 1240 matching lines...) Expand 10 before | Expand all | Expand 10 after
1467 void RenderLayerScrollableArea::setTopmostScrollChild(RenderLayer* scrollChild) 1461 void RenderLayerScrollableArea::setTopmostScrollChild(RenderLayer* scrollChild)
1468 { 1462 {
1469 // We only want to track the topmost scroll child for scrollable areas with 1463 // We only want to track the topmost scroll child for scrollable areas with
1470 // overlay scrollbars. 1464 // overlay scrollbars.
1471 if (!hasOverlayScrollbars()) 1465 if (!hasOverlayScrollbars())
1472 return; 1466 return;
1473 m_nextTopmostScrollChild = scrollChild; 1467 m_nextTopmostScrollChild = scrollChild;
1474 } 1468 }
1475 1469
1476 } // Namespace WebCore 1470 } // Namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698