Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 418463002: Only use "final" on MSVS2012+, to keep pdfium building with 2010. (Closed)

Created:
6 years, 5 months ago by Nico
Modified:
6 years, 5 months ago
Reviewers:
Bo Xu
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Only use "final" on MSVS2012+, to keep pdfium building with 2010. BUG=pdfium:26 TBR=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/10e6c7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M core/include/fxcrt/fx_system.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
6 years, 5 months ago (2014-07-23 17:54:26 UTC) #1
Nico
6 years, 5 months ago (2014-07-23 17:55:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r10e6c7c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698