Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/libxml/BUILD.gn

Issue 418453002: Improve content test GN build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ppapi/ppapi_tests.gypi ('k') | ui/views/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Define an "os_include" variable that points at the OS-specific generated 5 # Define an "os_include" variable that points at the OS-specific generated
6 # headers. These were generated by running the configure script offline. 6 # headers. These were generated by running the configure script offline.
7 if (is_linux || is_android) { 7 if (is_linux || is_android) {
8 os_include = "linux" 8 os_include = "linux"
9 } else if (is_mac || is_ios) { 9 } else if (is_mac || is_ios) {
10 os_include = "mac" 10 os_include = "mac"
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 if (is_clang) { 165 if (is_clang) {
166 cflags = [ 166 cflags = [
167 # libxml passes `const unsigned char*` through `const char*`. 167 # libxml passes `const unsigned char*` through `const char*`.
168 "-Wno-pointer-sign", 168 "-Wno-pointer-sign",
169 169
170 # pattern.c and uri.c both have an intentional `for (...);` / 170 # pattern.c and uri.c both have an intentional `for (...);` /
171 # `while(...);` loop. I submitted a patch to move the `'` to its own 171 # `while(...);` loop. I submitted a patch to move the `'` to its own
172 # line, but until that's landed suppress the warning: 172 # line, but until that's landed suppress the warning:
173 "-Wno-empty-body", 173 "-Wno-empty-body",
174 174
175 # See http://crbug.com/138571#c8 175 # debugXML.c compares array 'arg' to NULL.
176 "-Wno-ignored-attributes", 176 "-Wno-tautological-pointer-compare",
177 ] 177 ]
178 if (is_mac) {
179 # Mac Clang warnings.
180 cflags += [
181 # debugXML.c compares array 'arg' to NULL.
182 "-Wno-tautological-pointer-compare",
183 ]
184 }
185 } 178 }
186 179
187 include_dirs = [ 180 include_dirs = [
188 "$os_include", 181 "$os_include",
189 ] 182 ]
190 } 183 }
OLDNEW
« no previous file with comments | « ppapi/ppapi_tests.gypi ('k') | ui/views/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698