Issue 418453002: Improve content test GN build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 418453002: Improve content test GN build (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews, darin-cc_chromium.org, jam, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Improve content test GN build Fix libxml clang warnings. Add ppapi_unittest_shared target. Rename ipc:test_support_ipc to ipc:test_support and use this target when needed (the places that wanted this incorrectly specified only "ipc". R=hclam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285027

Patch Set 1 #

Patch Set 2 : merge #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -32 lines)			Patch
M	BUILD.gn	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/test/BUILD.gn	View		7 chunks	+13 lines, -18 lines	0 comments	Download
M	ipc/BUILD.gn	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	ppapi/BUILD.gn	View		1 chunk	+23 lines, -0 lines	0 comments	Download
M	ppapi/ppapi_tests.gypi	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	third_party/libxml/BUILD.gn	View		1 chunk	+2 lines, -9 lines	0 comments	Download
M	ui/views/BUILD.gn	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/webview/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Alpha Left Google

On 2014/07/23 17:39:51, brettw wrote: nit: CL header has typo: Imrpove -> Improve. Otherwise LGTM.

6 years, 5 months ago (2014-07-23 17:42:32 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r285027.

Expand Messages | Collapse Messages